From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B6901DE4EF; Sat, 12 Sep 2026 14:07:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789222062; cv=none; b=PMbyjI3oGJxQPWpGe5SX2L1Wo2PjC2UBMM7kgDCg4nSGMeBMO5QeV19QywHhsUbenFjMDyYyxfLLf523u1DcGj8P5RU1Oki/WRhAPo3e4PnCyp/kgYD1jZgqNR5RGLRAezmKiybkpjG2699Qr/inIZIc/eh7KHQ+yD5ugaGmd5c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789222062; c=relaxed/simple; bh=+ucrSMWt7SApM64CFX7UEeoFPMx2IOdfRWko8jUKeI8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ufshyCtVOIRzwWlRL5o7+glj/JjVRBnT6aZlM3W7pLQXx7A/DxTpCU+BirE8/y2PQtEQx+pPYDa4V9M9vXSooCPF4hqMAqzQrgGf9/KaHdHYLM7qJa3uMmVav5bHUZ2AYoloQbe17VkkL06XxrmYIDz5IWZBWZai5B0ZcRVPodM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=g++btWPC; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="g++btWPC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28CF21F000FF; Sat, 12 Sep 2026 14:07:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789222061; bh=Z6BhzOMIq1ULJDS9ugywfx6DGioDqPccCSxZHU8bTNs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=g++btWPCB5eP2n8NM10FtsS43WTudyL5nAZFJLe4WhiCCOwKTybtdFudeNmiUDcY/ ApfyCDHbBq9cuaJuKVO4UUep9YFg8nrIrunCOrEE9Qgx6ycieI3qfMYPKqP79PUK1O F/d0uVgZAdHo9e0haz2dg23GQzcrxvB3MLm6hGt0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sashiko , Nilesh Javali , "Martin K. Petersen (Oracle)" Subject: [PATCH 6.6 0483/1424] scsi: qla2xxx: Serialize flash version read in reset handler Date: Sat, 12 Sep 2026 08:48:35 +0200 Message-ID: <20260912065618.101916908@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065607.279695368@linuxfoundation.org> References: <20260912065607.279695368@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nilesh Javali commit f606ed93de0c4f1e7e3618779e9fad731455314a upstream. The "update cache versions without reset" sysfs reset operation (0x20261) calls get_flash_version(), which reads hardware flash registers, without holding ha->optrom_mutex. The VPD update path serializes the same call under optrom_mutex, so this reset path can interleave its flash register accesses with a concurrent VPD or optrom flash operation and corrupt the reads. Hold ha->optrom_mutex across the get_flash_version() call to match the VPD update path. Fixes: 8c2cf7d4e387 ("[SCSI] qla2xxx: Add a new interface to update versions.") Reported-by: Sashiko Cc: stable@vger.kernel.org Signed-off-by: Nilesh Javali Link: https://patch.msgid.link/20260730155838.2119230-4-njavali@marvell.com Signed-off-by: Martin K. Petersen (Oracle) Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qla2xxx/qla_attr.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/scsi/qla2xxx/qla_attr.c +++ b/drivers/scsi/qla2xxx/qla_attr.c @@ -816,7 +816,9 @@ qla2x00_sysfs_write_reset(struct file *f "Unable to allocate memory for VPD information update.\n"); return -ENOMEM; } + mutex_lock(&ha->optrom_mutex); ha->isp_ops->get_flash_version(vha, tmp_data); + mutex_unlock(&ha->optrom_mutex); vfree(tmp_data); break; }