From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7A874746A9; Sat, 12 Sep 2026 12:15:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789215334; cv=none; b=R12diVRMqDYU4ciIL01e6jclXwafxRPpKMdWJF+wZuIKEL8efiMyhbibif5Odweu4qUG8MNB+/s11NiVLSsmCM34ZEt1bbKf6B5kiR1Ot1AAm7kZaBpfczUD968hXE9d6BGIao7vYwsvfOo4DUgoOKOz2ezJcBu9jif+K+Yk83A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789215334; c=relaxed/simple; bh=50jHQUGRwSrQP0tAF9k5uXASM9nZ2dgkyJHxmMEvHaY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s/VmpWKrC//Cml2KUKteWooIUGmA2GDWXNcqEjw14Ff65QlWrVhSCtArmZX32Q2G1ffOrj35o+p4LbFDiBPIcrHXb04gawt8GbZt7nJSlQGrTlcNNaEPIR2xj8UiUv7tysE1Lnu21hyl7S52aJvHegZr/8T2toC28noLZb327jc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=nv2IGUka; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="nv2IGUka" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACA761F000FF; Sat, 12 Sep 2026 12:15:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789215332; bh=zjOnV3vDQfXYaZ5iL+UyZDBSHba1yl/LekV6J4r/xrw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=nv2IGUkaL2t7F+ej+2qIAcccTUT49mgTZBHOICNfIV1tbtBw416bgyTCWhPB0wkU+ 0zvGu2xbxlmu2joGbY2ZfYJ3hGvDWPsKPzZJlRUeFF9g8ufl6Tj541EA4M2GLUFcOW bJzUrgI6RkAI+xceq1PPQwVX10uByIM6K6lBOsFQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Evgenii Burenchev , Takashi Iwai , Sasha Levin Subject: [PATCH 6.12 0508/1376] ALSA: hpi: Check transport errors during HPI6000 adapter initialization Date: Sat, 12 Sep 2026 08:48:54 +0200 Message-ID: <20260912065618.859596801@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065607.535295758@linuxfoundation.org> References: <20260912065607.535295758@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Evgenii Burenchev [ Upstream commit cc15c329663e3ef1aeed0b68e49a5d5ce4ae0d5c ] create_adapter_obj() retrieves adapter information by calling hpi6000_message_response_sequence(). This function reports transport-level errors through its return value and DSP-reported errors via hr0.error. The current code only checks hr0.error, causing transport-level errors to be ignored. As a result, adapter initialization may continue with an invalid response. Check the return value of hpi6000_message_response_sequence() before examining hr0.error. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 719f82d3987a ("ALSA: Add support of AudioScience ASI boards") Signed-off-by: Evgenii Burenchev Link: https://patch.msgid.link/20260708141147.18253-1-evg28bur@yandex.ru Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/pci/asihpi/hpi6000.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sound/pci/asihpi/hpi6000.c b/sound/pci/asihpi/hpi6000.c index 72aa135d69f85..8aa5832f1f2a5 100644 --- a/sound/pci/asihpi/hpi6000.c +++ b/sound/pci/asihpi/hpi6000.c @@ -537,6 +537,11 @@ static short create_adapter_obj(struct hpi_adapter_obj *pao, hr1.size = sizeof(hr1); error = hpi6000_message_response_sequence(pao, 0, &hm, &hr0); + if (error) { + HPI_DEBUG_LOG(ERROR, "message transport error %d\n", + error); + return error; + } if (hr0.error) { HPI_DEBUG_LOG(DEBUG, "message error %d\n", hr0.error); return hr0.error; -- 2.53.0