From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A08F214A84; Sat, 12 Sep 2026 12:34:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789216442; cv=none; b=qAOWjflMqGZl8D1pnaaXuHCjIoLu6/LdhzsDI8wrKzJXOMYookmjHPegG96eXTjjqImicRQkwHTzIRXO6+wZl+mbKl0GYZg1b9oqE+AfMczNTsxgZ2+gYQwCH67UncgOsOaVhjae2/Dj4PjmyNtQh8JRvxfAzLELqBON3jQJwoo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789216442; c=relaxed/simple; bh=NcrNdCGvmeExxLzQVOrLvBi5AY2HLvv+ZZ3BKG/fzFQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ePXSbWpMokoMluGY57HvuyMUAr4/poT10Q+PdtAdWbsXfvTo4IPq+l0dCELkx/kmr31rzDmSu9J6d6qzwf9KTraQ66A5Dr8MyLw+PoM/pGrMPYGn4yEY6PWhBWPq8CAPoXnvfXp7Kp2Ow+4NV/his4b2ysfRUSyN8T52RKDBjNQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=J3BWhW+L; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="J3BWhW+L" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 169811F000FF; Sat, 12 Sep 2026 12:33:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789216441; bh=DJa+/Hp793pZ75TEswmOXB6puY9MYxEUcCL2L+3G/uY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=J3BWhW+L4PGxgZkZvVpkdzz9muiRoY8EI/W/4ZXaF/DcfYHnwPxtXzBUjyhMjePl4 U1ybZdZfPJQO0LR7ipwU51UVayUYhbAOgb0A3ZUaTFqLb9R4REa9Y9WEU2JVLrYnd8 iFKfSpnKyZraUB4+/9XwUBlx8wuSQcYjE54uFKnI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Abdun Nihaal , Ping-Ke Shih , Sasha Levin Subject: [PATCH 6.12 0735/1376] wifi: rtlwifi: pci: fix error path in rtl_pci_probe() Date: Sat, 12 Sep 2026 08:52:41 +0200 Message-ID: <20260912065623.925978274@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065607.535295758@linuxfoundation.org> References: <20260912065607.535295758@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Abdun Nihaal [ Upstream commit 3c2999d13eeb222ae56631aeb7ca248090f2b210 ] In the last error path in rtl_pci_probe(), the cleanup functions are skipped due to a wrong goto label. Moreover, the successful call to rtl_init_rfkill(), ieee80211_register_hw(), rtl_debug_add_one() have to be reverted. Fix this issue by updating the labels and adding the relevant cleanup functions to the last error path. Fixes: 0c8173385e54 ("rtl8192ce: Add new driver") Signed-off-by: Abdun Nihaal Acked-by: Ping-Ke Shih Signed-off-by: Ping-Ke Shih Link: https://patch.msgid.link/20260723120118.145383-1-nihaal@cse.iitm.ac.in Signed-off-by: Sasha Levin --- drivers/net/wireless/realtek/rtlwifi/pci.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c b/drivers/net/wireless/realtek/rtlwifi/pci.c index f0010336e78c1..8fb9604c3c533 100644 --- a/drivers/net/wireless/realtek/rtlwifi/pci.c +++ b/drivers/net/wireless/realtek/rtlwifi/pci.c @@ -2226,13 +2226,17 @@ int rtl_pci_probe(struct pci_dev *pdev, rtl_dbg(rtlpriv, COMP_INIT, DBG_DMESG, "%s: failed to register IRQ handler\n", wiphy_name(hw->wiphy)); - goto fail3; + goto fail6; } rtlpci->irq_alloc = 1; set_bit(RTL_STATUS_INTERFACE_START, &rtlpriv->status); return 0; +fail6: + rtl_deinit_rfkill(hw); + rtl_debug_remove_one(hw); + ieee80211_unregister_hw(hw); fail5: rtl_pci_deinit(hw); fail4: -- 2.53.0