From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1727F4BEE5C; Sat, 12 Sep 2026 14:39:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789223954; cv=none; b=MNk30zTwwCOd0fxOGNzR9M8X0v5tFbPDASyAmRuDzfMaEqiT5VTbPycaoxHKOLWOHJVXgFzVbFFN9z6ymNO5r+KPLyG6gYaNJL6uinHQ/pvPLX44fyRZpwPtD6uQgrMEmG0Z76H9xZcsH5khJz2OHP7aaeLMQ4Vgtmme7UK+2+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789223954; c=relaxed/simple; bh=FPE+5DJQxR+5sHPWdUHXMa2hiLlzRvOLCiGyVtqaQm0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t45bOSONpe1AemG4eTcu7dAbFok3BERizYtDOJYPsbidg/ZYcc0FTOcCDj/WIojjdxmiBo8cx9GdrGSS70ncWdkfB8PqzyQqPVwrcE9RGzPOrclXTq7uZkILaN1ScMIGDoj27rauLbLf50TUE90HUF0FjsX6+z/4CAmvMEOsUUw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=WPVMRKLP; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WPVMRKLP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 748C61F000FF; Sat, 12 Sep 2026 14:39:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789223952; bh=WogpM7Zi6Rw+AHK8EB05qSyk7QU3a+viwAcKOL4IQU4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=WPVMRKLP4+FxtXVf8zi/EpJfFU4sbW5veZGvDGGXCrJw41U13S9iW4PLlI95NVANr HYtxEKmAPh3mI/YDB+bkeiXUvTgRYrOY4vNhfNRN7thfNjFOQdlkkyErdCUUNMP+45 G9WErkXrHPt+YzGZUgKxGPWmNKQc4RG4LOICi2ks= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bjorn Andersson , Mukesh Ojha , Konrad Dybcio , Bjorn Andersson , Sasha Levin Subject: [PATCH 6.6 0893/1424] remoteproc: Allow shutdown of crashed processors Date: Sat, 12 Sep 2026 08:55:25 +0200 Message-ID: <20260912065627.327048723@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065607.279695368@linuxfoundation.org> References: <20260912065607.279695368@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bjorn Andersson [ Upstream commit 2482ca875ef5993df8daee563033d70e2523a25f ] rproc_shutdown() rejects a remoteproc in RPROC_CRASHED state, and rproc_del() ignores that error. The result of these two decisions is that a user cannot stop a remoteproc that with recovery disabled that has entered a crash state, and removal of an associated remoteproc driver will release resources without first stopping the remoteproc. Allow rproc_shutdown() to stop crashed processors. Propagate the crash state to subdevice teardown, to allow subdevices to dismantle things appropriately. Assisted-by: OpenCode:GPT-5.5 Fixes: 5e6a0e05270e ("remoteproc: core: Move state checking to remoteproc_core") Signed-off-by: Bjorn Andersson Reviewed-by: Mukesh Ojha Reviewed-by: Konrad Dybcio Link: https://lore.kernel.org/r/20260723-rproc-rmmod-not-crashing-v1-1-546dfd5de0e6@oss.qualcomm.com Signed-off-by: Bjorn Andersson Signed-off-by: Sasha Levin --- drivers/remoteproc/remoteproc_core.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index dec3e80810fe7..b2d86a6e32bfa 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -1988,6 +1988,7 @@ EXPORT_SYMBOL(rproc_boot); int rproc_shutdown(struct rproc *rproc) { struct device *dev = &rproc->dev; + bool crashed; int ret; ret = mutex_lock_interruptible(&rproc->lock); @@ -1997,16 +1998,18 @@ int rproc_shutdown(struct rproc *rproc) } if (rproc->state != RPROC_RUNNING && - rproc->state != RPROC_ATTACHED) { + rproc->state != RPROC_ATTACHED && + rproc->state != RPROC_CRASHED) { ret = -EINVAL; goto out; } + crashed = rproc->state == RPROC_CRASHED; /* if the remote proc is still needed, bail out */ if (!atomic_dec_and_test(&rproc->power)) goto out; - ret = rproc_stop(rproc, false); + ret = rproc_stop(rproc, crashed); if (ret) { atomic_inc(&rproc->power); goto out; -- 2.53.0