From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49C6237F8B1; Sat, 12 Sep 2026 10:00:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789207226; cv=none; b=W+NbeRPjbvgOxm9Cyc7UOEEQICizzDiAGF+n/fPlEpgYfVjJC5qlpSgPHgwrlNa4THNIzcDxCx6LebAZ2U/uEd5pBKzg2UTqd8duU8LDin+UwLs2jXOg8WoOAWBSPIFncmzbT7UuMNucS64XbIJDtNud9eOE+G/o4/HWLPMm0PU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789207226; c=relaxed/simple; bh=T71y7nhyXRSV4703fBSHg/2L0CODEKL8+uODg9K68sQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QrxuAYvjakOEckR/LVSWjTjAlZw0K0u/H+4K0tKwpSzd7Lu2BBQwDduMKdzVoLMNSdMPW2iNim+gei/I9QAiA8MtOBSHVAatUaWbQulyAy5XvtxemM5CuNRKoB9lPn3jHyVFssNqzcZ+Sui4DenaBJbwMKhfnkJXoQg7M+AufFY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UT/N/JtF; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UT/N/JtF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E41441F000FF; Sat, 12 Sep 2026 10:00:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789207224; bh=+GhLSCKdLuekhi3aLETXZ4p6QcFXgjye3jEqhIdsL3U=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=UT/N/JtFd5CW00dhX/ekpnWUbMh4iHpBLw8VOts5mDFCAUj8IePA2uN410eXGynxx rEL9VWFlNyE6Zllvvnd+02zSV/5kWVl9nNJBZL2LA+lIioZLLmmjNucm7zeuXQf237 e6S8fBrE2SaDOJAfD7SERKe5Xzl70+H0OZiHh8ec= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Laxman Acharya Padhya , Linus Walleij , Sasha Levin Subject: [PATCH 6.18 0326/1518] drm/panel: samsung-s6d16d0: Power off on prepare failure Date: Sat, 12 Sep 2026 08:41:35 +0200 Message-ID: <20260912065630.848427881@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065623.398859879@linuxfoundation.org> References: <20260912065623.398859879@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Laxman Acharya Padhya [ Upstream commit a9f950adfe2147318d75e7a6eab5e814851802ac ] If enabling tearing mode or exiting sleep mode fails after the regulator is enabled, s6d16d0_prepare() returns without asserting reset or disabling the supply. Since the DRM panel core leaves the panel unprepared, a later unprepare call skips the driver callback and the supply remains enabled. Assert reset and disable the supply before returning the DSI command error. Fixes: ac1d6d74884e ("drm/panel: Add driver for Samsung S6D16D0 panel") Assisted-by: Codex:gpt-5 Signed-off-by: Laxman Acharya Padhya Signed-off-by: Linus Walleij Link: https://patch.msgid.link/20260704070648.35249-1-acharyalaxman8848@gmail.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/panel/panel-samsung-s6d16d0.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c index ba1a02000bb9d..04e19b5f22f8b 100644 --- a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c +++ b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c @@ -89,16 +89,22 @@ static int s6d16d0_prepare(struct drm_panel *panel) MIPI_DSI_DCS_TEAR_MODE_VBLANK); if (ret) { dev_err(s6->dev, "failed to enable vblank TE (%d)\n", ret); - return ret; + goto err_power_off; } /* Exit sleep mode and power on */ ret = mipi_dsi_dcs_exit_sleep_mode(dsi); if (ret) { dev_err(s6->dev, "failed to exit sleep mode (%d)\n", ret); - return ret; + goto err_power_off; } return 0; + +err_power_off: + gpiod_set_value_cansleep(s6->reset_gpio, 1); + regulator_disable(s6->supply); + + return ret; } static int s6d16d0_enable(struct drm_panel *panel) -- 2.53.0