From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2BC8470137; Sat, 12 Sep 2026 10:50:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789210206; cv=none; b=WE0O7AxzM2r+QFln/JfmT+JRnWmWxLmpsb0ltQDKvmZqwaOmswxzp7gBuzTQTxVLKZ43hyUiJjSqaBOTSUEV9bTzaAf0vz/z7xIKP7wdegp8/5xm0mzp517pdrhyAl5RefecJyKXFNfjsIo+xB2uMA+fgIYLNeTwYyhwr6Sbdyc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789210206; c=relaxed/simple; bh=wEMQNrKm1jm5g3ItSf1p8giC4/3ls6xdWxSH4bvfXPM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=L3MNOMyGwIEsLt3A8+VRpLV3/75ZnB2eN6Hv3nSBe8MlWp0PNnQLsaihov84iwnhcYVtgzx6/kjnzgWAv2CoIWWhCjhwW8gW+ijKkkPXb0m/I14WB4nR1jWY/lRjQXIhwfKxjO9/SpMeXUQ4Rwx+FDK44fZeQpCa1jgl9zL8OhM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Kt1qcNQH; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Kt1qcNQH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B60391F000FF; Sat, 12 Sep 2026 10:50:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789210202; bh=5lvUXnIewqrDdqM4Hcio00PToOlxAbj2zd0oClqa2Ks=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Kt1qcNQH5/XNrCdsbuU2CUxQPO3+htBVKGxDxo0tOFP/aU1VlzP/YfNlA1zSwOLx+ f3uBQUYmbo4j4IH+faC4NVS0wRTgPZpkp+EsOdz7HeuVWiLReeWhxzOn0RT6vUfwBh FZbUx6bYyBz08Lgdeu3YAxiFjS5IFWYlDewLxaeI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuho Choi , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 6.18 0979/1518] ACPI: video: Release PCI device reference after lookup Date: Sat, 12 Sep 2026 08:52:28 +0200 Message-ID: <20260912065645.605409786@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065623.398859879@linuxfoundation.org> References: <20260912065623.398859879@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yuho Choi [ Upstream commit 3d7ed9b8ef47b8bcae1fc3e12f7590a217862a89 ] video_detect_portege_r100() uses pci_get_device() only as a boolean check for the Trident CyberBlade XP4m32 device. pci_get_device() takes a reference on a matching PCI device, but the callback returns without releasing it. Drop the reference after selecting the vendor backlight quirk so the PCI device can be released normally. Fixes: 35a341c9b25d ("ACPI: video: Add acpi_backlight=vendor quirk for Toshiba Portégé R100") Signed-off-by: Yuho Choi Link: https://patch.msgid.link/20260807015734.913361-1-dbgh9129@gmail.com Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/video_detect.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c index 2c120ade8f51a..2a562cb425081 100644 --- a/drivers/acpi/video_detect.c +++ b/drivers/acpi/video_detect.c @@ -137,8 +137,10 @@ static int video_detect_portege_r100(const struct dmi_system_id *d) struct pci_dev *dev; /* Search for Trident CyberBlade XP4m32 to confirm Portégé R100 */ dev = pci_get_device(PCI_VENDOR_ID_TRIDENT, 0x2100, NULL); - if (dev) + if (dev) { acpi_backlight_dmi = acpi_backlight_vendor; + pci_dev_put(dev); + } return 0; } -- 2.53.0