From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CC18332610; Sat, 12 Sep 2026 07:42:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789198939; cv=none; b=jga8xDO5bQZBXsk0eioQAHDKcghUWuOjwyzmkXb0xAskkqmER0BwUDFOqtJdjc8md7D66Sm149ZPoxWdB6iky2arcHlM6x2AfD2r4NvY3f5ZtHROyww5O1mkXgPohVqIwBtXfJk8x7JHhD+mgpSdwq9HAtdqcHQU5ftwN3JyJ2U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789198939; c=relaxed/simple; bh=TcM7ot8H4fuELIRom/wz3Q/cYl4quFZHCzA4mulIBQY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XG5+4gt9SGGZUuUzx1Ji9aagV6xTh+cqzt6nYqqxLRW3g217R5OKdm9Bsj5vmS607aIL2dZU29FsVrTt5xpAFml/Tp0WLlErBFdh1fpI14CZEN3yjguhRWGHyxVcdLz4IKeGcvo58h0hd5YMHMDdPcJAMnB6mvd5dJUz7sKIb0U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TQUdrq3v; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TQUdrq3v" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1121F1F000FF; Sat, 12 Sep 2026 07:42:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789198938; bh=G9ZGgeyUbzEBJ2KIHxZmJd0S12uLdtdVqXxu6qNj/jk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=TQUdrq3vZAXEQ72Wqfb0nK5M/kmrYwtQ8qaGINClffnxAyVPKp6ALtezYSFlm2Ewo rEnKBkPNJhYHXV51LAmWkbZZKBWGolg8SMy6gAxC33jrgkFgkYaAajDssqGQoohHn4 tK8YAQJ65VXMdoagYfhVxbe/xRbEWobliBx35frU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thorsten Blum , Linus Walleij , Herbert Xu , Sasha Levin Subject: [PATCH 7.2 0483/1815] crypto: sl3516 - drop invalid sg_dma_len checks before DMA mapping Date: Sat, 12 Sep 2026 08:37:13 +0200 Message-ID: <20260912065700.230252240@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065648.999753832@linuxfoundation.org> References: <20260912065648.999753832@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thorsten Blum [ Upstream commit 3ae59a2eba64b3648f069aa52eeaaeefdfe4bb2f ] sg_dma_len() is only valid after mapping the scatterlist with dma_map_sg(). However, sl3516_ce_need_fallback() checks it before the source and destination scatterlists are mapped. Thus, a stale DMA length that is not a multiple of 16 could incorrectly force a software fallback when CONFIG_NEED_SG_DMA_LENGTH=y. Remove the invalid checks; the existing scatterlist length checks are sufficient. Fixes: 46c5338db7bd ("crypto: sl3516 - Add sl3516 crypto engine") Signed-off-by: Thorsten Blum Acked-by: Linus Walleij Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/gemini/sl3516-ce-cipher.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/crypto/gemini/sl3516-ce-cipher.c b/drivers/crypto/gemini/sl3516-ce-cipher.c index 583010b2d0071..02ec4282333b6 100644 --- a/drivers/crypto/gemini/sl3516-ce-cipher.c +++ b/drivers/crypto/gemini/sl3516-ce-cipher.c @@ -56,10 +56,6 @@ static bool sl3516_ce_need_fallback(struct skcipher_request *areq) ce->fallback_mod16++; return true; } - if ((sg_dma_len(sg) % 16) != 0) { - ce->fallback_mod16++; - return true; - } if (!IS_ALIGNED(sg->offset, 16)) { ce->fallback_align16++; return true; @@ -72,10 +68,6 @@ static bool sl3516_ce_need_fallback(struct skcipher_request *areq) ce->fallback_mod16++; return true; } - if ((sg_dma_len(sg) % 16) != 0) { - ce->fallback_mod16++; - return true; - } if (!IS_ALIGNED(sg->offset, 16)) { ce->fallback_align16++; return true; -- 2.53.0