From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 010F5271464; Sat, 12 Sep 2026 08:06:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789200371; cv=none; b=quIT6nSh4E7EiOwVUzHhcG07mAQRzHzJEiDqdaO3knGdaPA6S04FEScXdSJql/TNOa2RQlxDe+k3409cqA+w+JBregxRMLYW2jtL3NttebJsrtWU3ztvfsqy4ED560ASfPbhuWjmOZg2kzBGxSmOrH7prYzvhBnp9sLylSMEe4Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789200371; c=relaxed/simple; bh=EpjHp+7slD/8kDc88+0TgtBIDfCG+v3faqxLB6wH8JM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y8oGzVMIlOe0xA4DW8A7byqUgti5i8vvzdP/MVQzZq/X5MC1pfTVIUbPko64R+k47+MvuguhZLv10430OQQPaUbnVq7WQdtnHaJgcYf01KkaQ40I8XGFe67ma5BXj3Lms0z24r6JRRE2kbB1Xld6VtA9djqpFjDLLbVOpE2POg8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NdPlk4aV; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NdPlk4aV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F4881F000FF; Sat, 12 Sep 2026 08:06:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789200369; bh=8EzkEAWn9yEi4WomFcW94dNzI1VfsHYNCB0kt2FmfIQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=NdPlk4aVvfIx+nrTJCO7ooNXqmxVogk8XSLA39hmjNORi9LCPsJSDe1Xr2HdBtXRJ 5c+jW3v8jJ8YEWjnbYbkPSLe399hU/5hAJGWp5vfF9vuWPjDPkdP09XJcpCgIqkf+6 KzhNtI80ZdhG/RApKwMDpL+t3aF5QWsjQ8fIlWtE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Leon Romanovsky , Sasha Levin Subject: [PATCH 7.2 0733/1815] RDMA/mlx5: Fix stack out-of-bounds read in cc_params debugfs Date: Sat, 12 Sep 2026 08:41:23 +0200 Message-ID: <20260912065706.108697631@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065648.999753832@linuxfoundation.org> References: <20260912065648.999753832@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Leon Romanovsky [ Upstream commit 03826bc1fa6c90405bf05831f2b501a8368dcd27 ] get_param() reads a congestion parameter as a u32 but formats it with the signed "%d" into an 11-byte stack buffer. A value with bit 31 set, such as 0x80000000, renders as "-2147483648\n" whose full length is 12. snprintf() stores only 11 bytes yet returns 12, so simple_read_from_buffer() treats 12 bytes as valid and reads one byte past lbuf[]. Size the buffer for the widest unsigned decimal, format with "%u" to match the u32, and use scnprintf() so the length passed to simple_read_from_buffer() reflects the bytes actually stored. Fixes: 4a2da0b8c0782 ("IB/mlx5: Add debug control parameters for congestion control") Link: https://patch.msgid.link/20260726-get-param-leaks-kernel-stack-memory-v1-1-d61a4d39662d@nvidia.com Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/hw/mlx5/cong.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/cong.c b/drivers/infiniband/hw/mlx5/cong.c index d0edf83a2f20f..113e5f5fc6fb2 100644 --- a/drivers/infiniband/hw/mlx5/cong.c +++ b/drivers/infiniband/hw/mlx5/cong.c @@ -399,15 +399,13 @@ static ssize_t get_param(struct file *filp, char __user *buf, size_t count, int offset = param->offset; u32 var = 0; int ret; - char lbuf[11]; + char lbuf[12]; ret = mlx5_ib_get_cc_params(param->dev, param->port_num, offset, &var); if (ret) return ret; - ret = snprintf(lbuf, sizeof(lbuf), "%d\n", var); - if (ret < 0) - return ret; + ret = scnprintf(lbuf, sizeof(lbuf), "%u\n", var); return simple_read_from_buffer(buf, count, pos, lbuf, ret); } -- 2.53.0