From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77A9735AC1E; Sat, 12 Sep 2026 08:03:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789200190; cv=none; b=fVEsevDRSc23gQZeDPLNkOsRxSXjNKlUkNzr3mGByYiLHZhsEYI29jg9OiWvmX/hwPzLg7TPVjUixjIQVALfc3JES06FCK/jBIoqsA+F3LZJObE05J/09ghbc73e0mbPtklPaAzxA/uK2tWrTxU/mBKbnmREKluinsFNXa5fZxs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789200190; c=relaxed/simple; bh=RtBSYiFqqGsLnpd9VxX5w8TWBzeVyGIUUo4jWvmN6EI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j9XbnMKzShivNASOEm096XmXFFrlGcW5l0w4WJIkIu7WpdPy3JIuh0IFO/SqUu4u8BlwHa8e1bp2FyZXmIDR7Nr+cJXlPDq4AAL/Gl7mGfzZqt5/jjFfN1iwlDGygvjXKw3xEkd6UWwvwleNZwVeRdeikGijnhCT6yxmSbQjz3U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=oGT1R3Kn; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="oGT1R3Kn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A9121F000FF; Sat, 12 Sep 2026 08:03:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789200189; bh=oy0POftEByFFFHmKIJ+5uc5PmX+vtSD+ShD3Cfy//kQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=oGT1R3KnZwlFM4reklYDsU9DBON10QdpGbZThCyaogcDLaf/t1w3iteksGbJKu5L1 o7JQdILRgxW/W+gVn0hugBIgxBmk/6jPa1DH6ye44Jo8drNlu7z4GVdmC44kpCxCmg U30nspCT+bt8nXl67lZCmf1OmpgZSU6yqT4B6KRc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Christoph Hellwig , Guixin Liu , Keith Busch , Sasha Levin Subject: [PATCH 7.2 0740/1815] nvme-fc: unmap cmd_iu DMA on rsp_iu mapping failure in init_request Date: Sat, 12 Sep 2026 08:41:30 +0200 Message-ID: <20260912065706.277863322@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065648.999753832@linuxfoundation.org> References: <20260912065648.999753832@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guixin Liu [ Upstream commit f49d0c3a8d56a7cda1628ae17341a4a42063563c ] __nvme_fc_init_request() maps cmd_iu and then rsp_iu for DMA. If the rsp_iu mapping fails, the original code only recorded the error and fell through: it left the already-mapped cmd_iu unmapped and still marked the op as FCPOP_STATE_IDLE before returning. Since blk-mq does not call .exit_request() when .init_request() fails, the cmd_iu mapping is leaked for every op whose rsp_iu mapping fails. Jump to an error path on rsp_iu mapping failure that unmaps cmd_iu and returns the error without marking the op idle, so it stays in the FCPOP_STATE_UNINIT state set by the initial memset(). Fixes: e399441de911 ("nvme-fabrics: Add host support for FC transport") Reviewed-by: Christoph Hellwig Signed-off-by: Guixin Liu Signed-off-by: Keith Busch Signed-off-by: Sasha Levin --- drivers/nvme/host/fc.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c index 3082a17320b8f..48454cb7a0fcc 100644 --- a/drivers/nvme/host/fc.c +++ b/drivers/nvme/host/fc.c @@ -2100,9 +2100,15 @@ __nvme_fc_init_request(struct nvme_fc_ctrl *ctrl, dev_err(ctrl->dev, "FCP Op failed - rspiu dma mapping failed.\n"); ret = -EFAULT; + goto out_unmap; } atomic_set(&op->state, FCPOP_STATE_IDLE); + return 0; + +out_unmap: + fc_dma_unmap_single(ctrl->lport->dev, op->fcp_req.cmddma, + sizeof(op->cmd_iu), DMA_TO_DEVICE); out_on_error: return ret; } -- 2.53.0