From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E07E638D6A2; Sat, 12 Sep 2026 08:18:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789201122; cv=none; b=jlXinsM34BTPol/Bv59dQX05Iuafr2wLDxCRwlme9uoROwSB3Hy5REklSIhxQvnVCZZLwro3Y4UlGxA04B4sHFCJXZna2LBLwUB5b3YuwZTLGcagWAS9NJa3BFkMS20b2KA4sbNh14PNepzstN05YkoSJ2NvOeEGqEpwUGm7mQw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789201122; c=relaxed/simple; bh=1XfymFUa7VHWuB/XI1n+Z5rKpRaA9vlfKAsNqNxA4mU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XXfZS9DHLnBp9GyxdEAHkYKmEDFBih0yYsi4jdjaVKMcLcSvgOavRP4/wcisj+O0QHHtLBalbQtkEcTHSqyeVx02rG3bGWISGc52i9/qqGfJG+mVDnwf8NuNpfPMRlusnRWpwxyEsdFkowdLmzkvzU2p9ufklnSQhTPvr5YXa1M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=yLrRymud; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="yLrRymud" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 243101F000FF; Sat, 12 Sep 2026 08:18:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789201120; bh=5qyG64IfwviWjjQTnsrsWhJ5E1n7C40XYfVfaIoRaQk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=yLrRymudL9S5IRN7LQs5NvdbZhRmMvWo19aJQ9TJGlRK+afV5RHV4fndJ/050i4sg WIhzczELtTHu/e494RciqOMbtYit32h02j0FdiM/CYKVhTRfEYDjY7JlZiyNZrtxuP QOrkcfBaq0Y/uc97PXaY0N4/5blJ4a9X+WnkLfjw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, sashiko-bot , "Zhang, Yanmin" , Arnaldo Carvalho de Melo , Namhyung Kim , Sasha Levin Subject: [PATCH 7.2 0931/1815] perf machine: Check snprintf truncation for guest kallsyms path Date: Sat, 12 Sep 2026 08:44:41 +0200 Message-ID: <20260912065710.802365751@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065648.999753832@linuxfoundation.org> References: <20260912065648.999753832@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Arnaldo Carvalho de Melo [ Upstream commit d04ef71492fad7230d474efe33d05f4c0563d409 ] machines__create_guest_kernel_maps() builds the guest kallsyms path with snprintf() without checking the return value. A truncated path could pass the access() check if a prefix directory happens to contain a file named "kallsyms", leading to the wrong file being used for symbol resolution. Check for truncation and skip the directory. Fixes: a1645ce12adb ("perf: 'perf kvm' tool for monitoring guest performance from host") Reported-by: sashiko-bot Cc: Zhang, Yanmin Assisted-by: Claude:claude-opus-4.6 Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Namhyung Kim Signed-off-by: Sasha Levin --- tools/perf/util/machine.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index 48c4b963e8097..f86b3b7df742e 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c @@ -1269,9 +1269,14 @@ int machines__create_guest_kernel_maps(struct machines *machines) free(namelist[i]); continue; } - snprintf(path, sizeof(path), "%s/%s/proc/kallsyms", - symbol_conf.guestmount, - namelist[i]->d_name); + if (snprintf(path, sizeof(path), "%s/%s/proc/kallsyms", + symbol_conf.guestmount, + namelist[i]->d_name) >= (int)sizeof(path)) { + pr_debug("Guest kallsyms path too long for %s. Skipping.\n", + namelist[i]->d_name); + free(namelist[i]); + continue; + } if (access(path, R_OK)) { pr_debug("Can't access file %s\n", path); free(namelist[i]); -- 2.53.0