From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 163444A0F14; Thu, 17 Sep 2026 15:51:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789660311; cv=none; b=EEQZtpfhfZDKsU6kZXmCxy6/4mwY8Ljmt8WIl+MmnRJXwe/W4e2WqNfz2e/owEJ8WJlk8dcg2HLwOpbuJHiMeTy+8t5klGB0IvKLHRagu99wM5N57uBwKlKRWLE9Cnu6HaPDLsqrcT2/pl3U8Lo1Aa/vghE6ZSSC3euuKR1Xp+Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789660311; c=relaxed/simple; bh=ofz4vOalD9AUMqMfszxysUGtDL/zCBS2aFarGPJuebA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QYCZlDl4v44z/MrlUpxBvxDtNemhV6MKaEzYKXxSUba7mLbjprH+/Uf0wHuiP8L6qUBfueIbQF6UDv9iG5BX42tGonq/qksEWiaDp0JLgLcG8OxrIiyRw7PGm0174VLuB/rwkzMMWXp6VR3sEqdifkp7OEBDAvmLvEV4aBEzwTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=dUcDea8H; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dUcDea8H" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A41B1F000FF; Thu, 17 Sep 2026 15:51:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789660309; bh=LzXra9miWr39erii7/KyPONrni/makxtnXZLuuDWv1w=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=dUcDea8Hp72sLt2HaniN1Thnaj+p/FqtAw702eyP4jeEZ5ExCMeOsorFLWmKqdT/R jqSxfCR3Pc8TplKeildi36U8Q3WI6fiwKznovXzqJME353u2zfWthpGnDqw3n8o94E 3HeDfVlxpy1DwfzrnTuGdnp0DE9+yrpOjWyJkPIs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Donggeun Yoo , Andrew Lunn , Jakub Kicinski Subject: [PATCH 7.2 550/733] net: phy: dp83td510: handle the active-high LED polarity mode Date: Thu, 17 Sep 2026 16:14:18 +0100 Message-ID: <20260917151405.968541657@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260917151350.597953846@linuxfoundation.org> References: <20260917151350.597953846@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Donggeun Yoo commit 6ca81bbc31cdc964e4b74d17b86215d4a810a56f upstream. dp83td510_led_polarity_set() only recognizes PHY_LED_ACTIVE_LOW, so PHY_LED_ACTIVE_HIGH falls through to the default case and returns -EINVAL. of_phy_led() propagates the error, of_phy_leds() drops the LEDs registered so far and passes it on, and phy_probe() returns it. A device tree marking a DP83TD510 LED as 'active-high', which leds/common.yaml allows and ethernet-phy.yaml references for led@N nodes, thus leaves the mdio device unbound, so phy_attach_direct() falls back to the genphy driver, which cannot drive this 10BASE-T1L single-mode PHY, so the interface has no usable link. The callback initializes polarity to DP83TD510E_LED_POLARITY(index), which is the active-high setting, so the request is already satisfied and only the case label is missing. Cc: stable@vger.kernel.org Fixes: 5b281fe7e396 ("net: phy: dp83td510: introduce LED framework support") Signed-off-by: Donggeun Yoo Reviewed-by: Andrew Lunn Link: https://patch.msgid.link/20260908105959.70453-3-donggeunyoo.kernel@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/phy/dp83td510.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/net/phy/dp83td510.c +++ b/drivers/net/phy/dp83td510.c @@ -439,6 +439,9 @@ static int dp83td510_led_polarity_set(st case PHY_LED_ACTIVE_LOW: polarity = 0; break; + case PHY_LED_ACTIVE_HIGH: + polarity = DP83TD510E_LED_POLARITY(index); + break; default: return -EINVAL; }