From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E2FB501284; Thu, 17 Sep 2026 16:09:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789661354; cv=none; b=gTiyde2unq730MJmPSVWqhmsdnSHEKlLAA1n6AQhIspeac82sRH4Zy5Dzxe0BNJRWN/Pl7Gc1womeONidt0T71dd8ZQr26RIL9uptyEVlwmty6KrZCqMZQ3iRpRlPt3xi+V3W/hLYN8GaVIKQcM7CP3ZsWMf6AlXpxotbXlCDOc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789661354; c=relaxed/simple; bh=gT1cHa1ztvBpc+7Q0n386EBpTh7sXf/nvKFpqea1Mms=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B7vjbzIj9mmewJ3rKXsTSXDrDMwKT3VZlbwlxsyvpfHqQKrVlpnpIsHMjq8lpZ7/P+fYVw2AwtXA3qWURY3fZVUTNT1yAbwaTGptGmDC44kTOJgXfj++FgoiBoSjGPsOgoyB/bSi08fVgWMff+0XQey1QlNQB/bYYGa7h5bc3+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OSs2aFB5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OSs2aFB5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E87D81F00899; Thu, 17 Sep 2026 16:09:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789661353; bh=Cr6uDzyv39nenjp+n7kP+MKREQIlHqQmMZE/d7GWd9Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=OSs2aFB55/jWu8A3bAruR3VUvlaNB0CFBST0qRwogqELm6E3TsvGmI+J2VHi7IP4x r4WRR5dwbkRo8f/jOsBuSY5pxcFyngzkq0Fs2dbNxe4blGlOCPjBekP0l+HBRncyoK Pnhl9F515Dls1Ah69W4kWfhz5LNEOi4QLMLQ1pYk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Christoph Hellwig , Hannes Reinecke , Sagi Grimberg , Daniel Wagner , Maurizio Lombardi , Keith Busch , Sasha Levin Subject: [PATCH 6.18 0166/1250] nvme-core: align fabrics_q teardown with admin_q in nvme_free_ctrl Date: Thu, 17 Sep 2026 15:59:21 +0100 Message-ID: <20260917151556.589737033@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260917151551.901433442@linuxfoundation.org> References: <20260917151551.901433442@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maurizio Lombardi [ Upstream commit f702badaf7d31dc3dea6c66da92b5f35fadd89dc ] Currently, the final reference for the fabrics admin queue (fabrics_q) is dropped inside nvme_remove_admin_tag_set(). However, the primary admin queue (admin_q) defers dropping its final reference until nvme_free_ctrl(). Move the blk_put_queue() call for fabrics_q from nvme_remove_admin_tag_set() to nvme_free_ctrl(). This aligns the lifecycle management of both admin queues, ensuring they are freed symmetrically when the controller is finally torn down. Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke Reviewed-by: Sagi Grimberg Reviewed-by: Daniel Wagner Signed-off-by: Maurizio Lombardi Signed-off-by: Keith Busch Signed-off-by: Sasha Levin --- drivers/nvme/host/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index dcf729aacb1f7..f370dce6f91dd 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -4926,10 +4926,8 @@ void nvme_remove_admin_tag_set(struct nvme_ctrl *ctrl) */ nvme_stop_keep_alive(ctrl); blk_mq_destroy_queue(ctrl->admin_q); - if (ctrl->ops->flags & NVME_F_FABRICS) { + if (ctrl->fabrics_q) blk_mq_destroy_queue(ctrl->fabrics_q); - blk_put_queue(ctrl->fabrics_q); - } blk_mq_free_tag_set(ctrl->admin_tagset); } EXPORT_SYMBOL_GPL(nvme_remove_admin_tag_set); @@ -5071,6 +5069,8 @@ static void nvme_free_ctrl(struct device *dev) if (ctrl->admin_q) blk_put_queue(ctrl->admin_q); + if (ctrl->fabrics_q) + blk_put_queue(ctrl->fabrics_q); if (!subsys || ctrl->instance != subsys->instance) ida_free(&nvme_instance_ida, ctrl->instance); nvme_free_cels(ctrl); -- 2.53.0