From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA64F5304C5; Thu, 17 Sep 2026 17:01:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789664471; cv=none; b=oqXybLZJrbznq9tBQjalRrwx6b/hHxNhI0lrpD7ug0MLhWcxHTpK/K7ITzgynGIYP6jNZBXtssXsxwxrAbx3s/buwaa2ha9vT69HjO/h8ljEUQdavHhkLISSGItNH2bIFZof2+KidoU60RK00/Cq2HdMzRNQTy4D2h90qt1P3EE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789664471; c=relaxed/simple; bh=FVpqpfqbnd1irbKH0Js1agN1RJFWX7Coy+bouY0C6HY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bKeK0U5IHid9xboPWFZYCZn9UjbDRGlePj/fQ5PDLPAyKP1nfnOIwDDgZk4a9dT1p6CAxYByqmFjpHiUAFoq4LHIfwb1F6eQidq9Dd4GHYbc6tOXOGzkx+kGqrEIUqdOTtmV9rAsBjmqc3BLNK1OtHm40VxNPKd2WYRrPzZ2Qjk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=dra50UlI; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dra50UlI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AA611F000FF; Thu, 17 Sep 2026 17:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789664470; bh=n6ErRYx30kZTEHjaVPi9SajQHs4Gp4CjubLi3FugnDc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=dra50UlIQ/eKc9CbhdS1XezmUDpsBvRAgv7wBxjBNH42LTMGvArCciyshoAKkaySz oV5vW35VbBUl8epmE+sWy3FZzSRjtQlDFq+yetuphCmT5cvr7gEPVrWyf4guV3SWiz VxivnO9Vy3kpxYTAls3JiC69RXZO5O6kQKFfyYyM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jan Kara , Breno Leitao , Al Viro , Sasha Levin Subject: [PATCH 6.18 0356/1250] configfs_depend_prep(): pass configfs_dirent instead of dentry Date: Thu, 17 Sep 2026 16:02:31 +0100 Message-ID: <20260917151601.717840977@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260917151551.901433442@linuxfoundation.org> References: <20260917151551.901433442@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Al Viro [ Upstream commit 764682e0118432260191d194edbdaff208260483 ] Again, the only thing it uses dentry for is dentry->d_fsdata; for the recursive call the situation is the same as with configfs_detach_prep() and the same observation about ->s_dentry->d_fsdata applies. Reviewed-by: Jan Kara Reviewed-by: Breno Leitao Signed-off-by: Al Viro Signed-off-by: Sasha Levin --- fs/configfs/dir.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c index 68203952766e6..bfecb68a83797 100644 --- a/fs/configfs/dir.c +++ b/fs/configfs/dir.c @@ -1088,15 +1088,12 @@ static int configfs_dump(struct configfs_dirent *sd, int level) * much on the stack, though, so folks that need this function - be careful * about your stack! Patches will be accepted to make it iterative. */ -static int configfs_depend_prep(struct dentry *origin, +static int configfs_depend_prep(struct configfs_dirent *sd, struct config_item *target) { - struct configfs_dirent *child_sd, *sd; + struct configfs_dirent *child_sd; int ret = 0; - BUG_ON(!origin || !origin->d_fsdata); - sd = origin->d_fsdata; - if (sd->s_element == target) /* Boo-yah */ goto out; @@ -1104,8 +1101,7 @@ static int configfs_depend_prep(struct dentry *origin, if ((child_sd->s_type & CONFIGFS_DIR) && !(child_sd->s_type & CONFIGFS_USET_DROPPING) && !(child_sd->s_type & CONFIGFS_USET_CREATING)) { - ret = configfs_depend_prep(child_sd->s_dentry, - target); + ret = configfs_depend_prep(child_sd, target); if (!ret) goto out; /* Child path boo-yah */ } @@ -1126,7 +1122,7 @@ static int configfs_do_depend_item(struct dentry *subsys_dentry, spin_lock(&configfs_dirent_lock); /* Scan the tree, return 0 if found */ - ret = configfs_depend_prep(subsys_dentry, target); + ret = configfs_depend_prep(subsys_dentry->d_fsdata, target); if (ret) goto out_unlock_dirent_lock; -- 2.53.0