From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7478750257D; Thu, 17 Sep 2026 17:09:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789664952; cv=none; b=HY67XYd2614l8NwFVW/5cDIElvEr0304Rn6F412jLmHyfv4t/pqgvpny2/pmO31Uq/nFf7/oBK+LeKV0/f3kUEENAG9fIu3Vz/xa0h6jPRBpAjbubU+Zf5lcJ2aUjnQ1U4NParNjKtFqC3ffX54JH8PTKW5XgddC1GW7bD/u96Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789664952; c=relaxed/simple; bh=c9f3s+wxRK+SOB306Nvjh+MC9IKvZmpmIR3/1hu6Ow4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fAC666wZ2WG11OCSlfJJxNSGovDmu4ofLeBUVJdsjxmnsDNGkKQSPs/fl7LG7l8JtRk6yZMLfXWkpOjXlcg7AECfGc1YFImeG2jKp17/fVrjxpMdw6SFeOF3l5X0XZxXbVHDalRdb2oBGMyadDiCc8cHNNbLhX1y4SUTk8hHLuU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=dG7lKkH4; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dG7lKkH4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB8AE1F000FF; Thu, 17 Sep 2026 17:09:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789664951; bh=I6T7tr3pKs6HMAla1zTdctc3qV0MyY11/yXj20Sno4A=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=dG7lKkH4592KYVJddEHZcfD162iJja1Tem2mVJpgvIeBIcogT7K2oz5sVEhD4m+Xm ulaP3u4uYuXFilsiBt+ZpYc16IqSzCcQ6zruiej8iX38Sl8pgwIa/BSlmBa16R1mdk GlWJhVU+82tPpCuk+zNSj377TxYhHCtkPE2cybdg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ibrahim Hashimov , Johannes Berg , Sasha Levin Subject: [PATCH 6.18 0542/1250] wifi: mac80211_hwsim: reject undersized HWSIM_ATTR_TX_INFO Date: Thu, 17 Sep 2026 16:05:37 +0100 Message-ID: <20260917151606.631526517@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260917151551.901433442@linuxfoundation.org> References: <20260917151551.901433442@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ibrahim Hashimov [ Upstream commit 3dc723ac78a6e4fa0fd49e27e487ed319da40a9f ] hwsim_tx_info_frame_received_nl() casts the HWSIM_ATTR_TX_INFO payload to a struct hwsim_tx_rate * and unconditionally reads IEEE80211_TX_MAX_RATES entries (8 bytes) from it. The policy only bounds the attribute from above (NLA_BINARY .len is a maximum) and the op sets GENL_DONT_VALIDATE_STRICT, so a short or zero-length attribute is accepted and the loop reads past the payload. Require the exact length in the policy, so a malformed attribute is rejected before the handler runs. Signed-off-by: Ibrahim Hashimov Assisted-by: AuditCode-AI:2026.07 Link: https://patch.msgid.link/20260721115346.17236-1-security@auditcode.ai Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- drivers/net/wireless/virtual/mac80211_hwsim.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/virtual/mac80211_hwsim.c b/drivers/net/wireless/virtual/mac80211_hwsim.c index 3d66f4aa8393e..90caa4290dc45 100644 --- a/drivers/net/wireless/virtual/mac80211_hwsim.c +++ b/drivers/net/wireless/virtual/mac80211_hwsim.c @@ -912,9 +912,9 @@ static const struct nla_policy hwsim_genl_policy[HWSIM_ATTR_MAX + 1] = { [HWSIM_ATTR_FLAGS] = { .type = NLA_U32 }, [HWSIM_ATTR_RX_RATE] = { .type = NLA_U32 }, [HWSIM_ATTR_SIGNAL] = { .type = NLA_U32 }, - [HWSIM_ATTR_TX_INFO] = { .type = NLA_BINARY, - .len = IEEE80211_TX_MAX_RATES * - sizeof(struct hwsim_tx_rate)}, + [HWSIM_ATTR_TX_INFO] = + NLA_POLICY_EXACT_LEN(IEEE80211_TX_MAX_RATES * + sizeof(struct hwsim_tx_rate)), [HWSIM_ATTR_COOKIE] = { .type = NLA_U64 }, [HWSIM_ATTR_CHANNELS] = { .type = NLA_U32 }, [HWSIM_ATTR_RADIO_ID] = { .type = NLA_U32 }, -- 2.53.0