From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 369FE421239; Wed, 23 Sep 2026 14:40:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790174448; cv=none; b=EBJqWT+P9v+wWC57ivJMAjwT7KD83wQj3lz42vfSx17sy7YJeGrUMuqdo+y5wMAQlkGgVJ3GUZ866o/p5tpaVY6m+1C4b6Bu5mNVu6pmr2Q6E8GFhry63YbDwNphXY7cJXyv30kVOqKa+MnMowgQd40OR2srd735YZbqJepGmXs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790174448; c=relaxed/simple; bh=b5hcnUXHmHXQnR0ifbv3zra8+iTQaMIXr2Y82NoTR5k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YdLwBt2fBlRnEy+SKRVFAkVLBG1g5Xg8AH7tRC4yl9raMtQB5EodImcQ7EwqCCe8Jd7AoyjSzqsI9Z7eo9WlPUCe/lrXMjnr4XgZeXIS8THYILXX2QelubOmpaEZaJM4hZRErvYpll2DKrMv01VHzrery+XtTVmQcwepHb8o85Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2SEITCgC; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2SEITCgC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 851A11F00893; Wed, 23 Sep 2026 14:40:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790174447; bh=RwNSLg/zUtG43vChmeLzu2aHQk/fsjrpCdyD6MPB9n4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=2SEITCgCrjrfAmPH6Tk49B4pMf22GKPaZeX4gr1hHSKoS/eIzvqk3pvER7a1/GPdz 01VPuTrJRizyMcWewkuNFgDHInzwJTGxtFqnd9IT99a+UiE6JgavF6d42M5Jcvtslu iusE/Cfrsbjj8U4Wj9WfTGnxBrO74cIiOzSMjVCI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Vega , Luxing Yin , Zihan Xi , Johannes Berg , Sasha Levin Subject: [PATCH 6.18 118/398] wifi: virt_wifi: dont transfer operstate before register Date: Wed, 23 Sep 2026 16:03:12 +0200 Message-ID: <20260923140646.502529365@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260923140643.441954610@linuxfoundation.org> References: <20260923140643.441954610@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zihan Xi [ Upstream commit e5c8d7acd31b27057ea42cd405d0b3ece097bc89 ] virt_wifi_newlink() calls netif_stacked_transfer_operstate() before register_netdevice(). If the lower device is dormant, that queues the new netdev on lweventlist while it is still uninitialized. If registration fails after that, for example because of an invalid name such as "bad/name", free_netdev() immediately frees the object. A later linkwatch_fire_event() then use-after-frees the list entry. Move the transfer to after netdev_upper_dev_link(), as macvlan and ipvlan already do. Fixes: c7cdba31ed8b ("mac80211-next: rtnetlink wifi simulation device") Reported-by: Vega Assisted-by: LLM Co-developed-by: Luxing Yin Signed-off-by: Luxing Yin Signed-off-by: Zihan Xi Link: https://patch.msgid.link/f5a832fb0ab228ce6e2b5a91fba4ca8b79198a2f.1788948455.git.zihanx@nebusec.ai Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- drivers/net/wireless/virtual/virt_wifi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/virtual/virt_wifi.c b/drivers/net/wireless/virtual/virt_wifi.c index b976b90c1c2d2..16d1d3cedd981 100644 --- a/drivers/net/wireless/virtual/virt_wifi.c +++ b/drivers/net/wireless/virtual/virt_wifi.c @@ -556,7 +556,6 @@ static int virt_wifi_newlink(struct net_device *dev, } eth_hw_addr_inherit(dev, priv->lowerdev); - netif_stacked_transfer_operstate(priv->lowerdev, dev); dev->ieee80211_ptr = kzalloc(sizeof(*dev->ieee80211_ptr), GFP_KERNEL); @@ -582,6 +581,8 @@ static int virt_wifi_newlink(struct net_device *dev, goto unregister_netdev; } + netif_stacked_transfer_operstate(priv->lowerdev, dev); + dev->priv_destructor = virt_wifi_net_device_destructor; priv->being_deleted = false; priv->is_connected = false; -- 2.53.0