From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6792C4A2058; Wed, 23 Sep 2026 14:43:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790174586; cv=none; b=QLfJ9JNtU8BL8Cod2L2rAte67kdOvozMEFsleo5JloZ4dPvZjtQjgIlbIiTlxQ65jH+u1pW7VPF4FfW9KwNXpJVs9jB3jGQD4AtG6e0LVzFcR2jw360k8ti/z7cPM/mbZD6MrUFe3qxm1Y3nd52QTCsNadWmug2YNhyqsoolgBc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790174586; c=relaxed/simple; bh=vilnHQ5WdlmwokMZTh4JWrsOLUcenIP2h+AGoNnmtm4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=O/Mg5N8GLxFOx5lPpOVR0y355ITDhlaJ5iAFBHr1ZhDPePA6HkxXPg2sEfmY/OZy967Sf9bPpEQwDFVqpLFNO2SY6OJKgeMcVZpl411oK+inRjH5xlt/vpoeNS0JABBNSphrMkznsXHB3hKP6oS4WHE0EHmyUtnQcRylRT/PeEg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=vq1ObHXt; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="vq1ObHXt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C86A51F000FF; Wed, 23 Sep 2026 14:43:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790174585; bh=TfginCgD2ZUd1yA4ohvxdDO7QK1U9x2RYQIH2TcSAdU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=vq1ObHXt5L98pA1i2UogFojcE5O8fOuwPXbVctYrK7gMYSI1cgNgjXVJRSXM32S2L REZ5Mdv837g79Rnvrp1It1xLEeQ7s5Ps7Nz/HYt6+ogctu8bZyw4o5xzLktUMwZZqc EYkQq9KJHhGPHj9UPOFB0HIvcjlxLQDkn9IKdTMg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Ritesh Harjani (IBM)" , R Nageswara Sastry , Shivaprasad G Bhat , Gautam Menghani , Madhavan Srinivasan , Sasha Levin Subject: [PATCH 6.18 162/398] powerpc/iommu: Fix the overflow validation in iommu_tce_check_ioba Date: Wed, 23 Sep 2026 16:03:56 +0200 Message-ID: <20260923140647.637811751@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260923140643.441954610@linuxfoundation.org> References: <20260923140643.441954610@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shivaprasad G Bhat [ Upstream commit 0b271f7d7f5ed45bc498a03ce0aa9cfd8402fc71 ] The commit b1af23d836f8 ("KVM: PPC: iommu: Unify TCE checking") unified IOBA parameter checking across KVM and VFIO into iommu_tce_check_ioba(). While doing so, the passed in argument npages is ignored and constant value '1' is used leaving out a possible overflow as the callers can legitimately be using npages > 1 for H_STUFF_TCE or H_PUT_TCE_INDIRECT cases. Fix this by accounting for 'npages', checking for arithmetic overflow, and verifying that the entire requested range (ioba - offset + npages) does not exceed the table capacity 'size'. Fixes: b1af23d836f8 ("KVM: PPC: iommu: Unify TCE checking") Reviewed-by: Ritesh Harjani (IBM) Tested-by: R Nageswara Sastry Signed-off-by: Shivaprasad G Bhat Signed-off-by: Gautam Menghani Signed-off-by: Madhavan Srinivasan Signed-off-by: Sasha Levin --- arch/powerpc/kernel/iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c index 244eb4857e7f4..0a7d14f651e8a 100644 --- a/arch/powerpc/kernel/iommu.c +++ b/arch/powerpc/kernel/iommu.c @@ -1075,7 +1075,7 @@ int iommu_tce_check_ioba(unsigned long page_shift, if (ioba < offset) return -EINVAL; - if ((ioba + 1) > (offset + size)) + if ((ioba + npages < ioba) || (ioba - offset + npages > size)) return -EINVAL; return 0; -- 2.53.0