From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3546E5172F9; Wed, 23 Sep 2026 14:19:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790173187; cv=none; b=LzvX/hLuknxKY2IaS8rWZbbRxMcKhyZL8hBj9JEtfBOCjQ/uKGf7BTjA04bHO2Qc7NOXT4JwgH+SeeFxXARL8iLFPXawItLq6tCpp715Mi3toX/DbU+NpAMwFZSzzrcVWHgDWtNG+nk9uByuWeHMXdG0SaTT8qywemCiSNVmV/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790173187; c=relaxed/simple; bh=GarwIrsQpfH/VT9Y3VYBB+lHHximamqJrMgzQGd8DVw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m1gNcfhckoZBVqLoPowTA0YpUSdql8z6FfwkheIgpy0K2mGZ0AHbdlROBvdDViDJSSfQm0YGvzyuCJeUJaIYXKga0M4adc4nxtRMFJfoi/FWqu81281WONmN/xRci0aYg5aYiob+xIjHrllq8Om1yDNjvvc138+bYufIeMR+nik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=FB7lxoCS; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FB7lxoCS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 873EF1F000FF; Wed, 23 Sep 2026 14:19:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790173186; bh=Qwc0pM49/DsG7s+Pmp3hw5ZMUX7dijZcXVnUPl+2/O8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=FB7lxoCS7Wi30rbq1ijhd9Rgzb68LZ4gO3h0KXFLMKcnS51NsA86gs3CccrP6nIUL 9kR7865eLSnyJl/FDk8Mnv3YjskzUHK0U2FQtRdTsPb5dpqhcH/cIFLiieX8jZSDPt 03ckpGlvoBym3gZBrlAhVIeOvnggGIU6dRYQ+pK0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Baineng Shou , Frank Li , Vinod Koul , Sasha Levin Subject: [PATCH 7.2 167/438] dmaengine: mmp_pdma: fix wrong sg length in mmp_pdma_prep_slave_sg() Date: Wed, 23 Sep 2026 16:03:08 +0200 Message-ID: <20260923140649.098146643@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260923140644.756254324@linuxfoundation.org> References: <20260923140644.756254324@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Baineng Shou [ Upstream commit 075bc7b1d3dde5ed43fbaabbc1a69f09b7fc3a47 ] In mmp_pdma_prep_slave_sg(), for_each_sg() iterates the scatterlist putting each entry into 'sg', but the entry length is read from 'sgl' (the list head) instead of 'sg' (the current entry): for_each_sg(sgl, sg, sg_len, i) { addr = sg_dma_address(sg); avail = sg_dma_len(sgl); /* should be 'sg' */ Consequently 'avail' is always the length of the first entry. For multi-sg lists this causes out-of-bounds reads when a later entry is shorter than the first, and silent data loss when it is longer. Single-sg or uniformly-sized lists happen to mask the issue. Fixes: c8acd6aa6bed3 ("dmaengine: mmp-pdma support") Signed-off-by: Baineng Shou Reviewed-by: Frank Li Link: https://patch.msgid.link/20260910021652.1296640-1-shoubaineng@gmail.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/mmp_pdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c index 78e3e07e681df..ed520737882bc 100644 --- a/drivers/dma/mmp_pdma.c +++ b/drivers/dma/mmp_pdma.c @@ -712,7 +712,7 @@ mmp_pdma_prep_slave_sg(struct dma_chan *dchan, struct scatterlist *sgl, for_each_sg(sgl, sg, sg_len, i) { addr = sg_dma_address(sg); - avail = sg_dma_len(sgl); + avail = sg_dma_len(sg); do { len = min_t(size_t, avail, PDMA_MAX_DESC_BYTES); -- 2.53.0