From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 106B75372FF; Wed, 23 Sep 2026 14:46:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790174793; cv=none; b=fC1P1b4Lb5ox6aBeJtT2GHr2w3AI7dS+UUTwONwdVWeKibVgqxa7QXsXStA30jOey09Jutnb7EPtqMnWSrFzEPiVOpedo870GLoQOE/SLVXwm+KLoaPrWV7Lhe2HFjRybUfRjOraNCWn92BjL129P28z5jSgTdwkgC3bVc/2z24= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790174793; c=relaxed/simple; bh=OFus7yV0NM2nSa6msaK55BMMJIeTczWupRGFWJoYApI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T465BB5wmtih2HSV/BRkDvBsyfeL/lX1rFt14ut3aHLA5Q6eqZVT2zni6/YxWjLwJgJnADqR3Db09o8m2hnSI0IksLZYoArghqLbZ/2xvegdval0cyGJLgUqaW5H2Et7AeenpKXiEJeUAtqBHlAjgfkvxi7w2/O8PxuzBDNfYSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=D7T3h/rr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="D7T3h/rr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69C3B1F00898; Wed, 23 Sep 2026 14:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790174792; bh=+PpDPyVggDSxDjeNyD/3o+eU+Rs68Xzm6pnStCh1ItI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=D7T3h/rraO052OWxnbi+32YSa2CngwuKv7aMtk+R4J7NebMwzezYVrfDzONBeu4fq 0UO7NxXP2IcFXNB4oJetu2tITGLWY8ELN1ixAdgbkLVdRBCPXhPBA/YtbFUJu73Uyu hhmqNBoWjLCC6yGAp3GpWI4ZZBG7c3KdAPrF8WLg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thomas Huth , Will Deacon Subject: [PATCH 6.18 227/398] kselftest/arm64: Fix size of thread_data values for pthread_join() Date: Wed, 23 Sep 2026 16:05:01 +0200 Message-ID: <20260923140649.303276864@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260923140643.441954610@linuxfoundation.org> References: <20260923140643.441954610@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thomas Huth commit 3d1ba5cbfb622025690c218d8f20da92a9ecb383 upstream. pthread_join() stores the thread's return value (a "void *", i.e. 8 bytes on 64 bit computers) into the address that is passed as second parameter. However, the entries of thread_data are only normal "int"s, i.e. only 4 bytes. The additional 4 bytes of the return value clobber whatever is adjacent on the stack, i.e. other members of the thread_data array (which will be re-written in the next iteration of the for-loop, so that nobody noticed this problem), or another other local variable on the stack for the last iteration. Use "intptr_t" to declare the thread_data array entries with the correct size. Fixes: 29f080881601c ("kselftest/arm64: check GCR_EL1 after context switch") Cc: stable@vger.kernel.org Signed-off-by: Thomas Huth Signed-off-by: Will Deacon Signed-off-by: Greg Kroah-Hartman --- tools/testing/selftests/arm64/mte/check_gcr_el1_cswitch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/tools/testing/selftests/arm64/mte/check_gcr_el1_cswitch.c +++ b/tools/testing/selftests/arm64/mte/check_gcr_el1_cswitch.c @@ -69,7 +69,7 @@ fail: int execute_test(pid_t pid) { pthread_t thread_id[MAX_THREADS]; - int thread_data[MAX_THREADS]; + intptr_t thread_data[MAX_THREADS]; for (int i = 0; i < MAX_THREADS; i++) pthread_create(&thread_id[i], NULL,