From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3822553A3B6; Wed, 23 Sep 2026 14:50:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790175013; cv=none; b=u1Jm2mVf2+/MxZDlt+1riH7Q26k3AX6y8+Ay9psNs6udmxx5xIvtqHu7t9jaMLlzkWh9K57BEqX2i4VOVnR/f2q1BGKLh/BFtTDNowJWqwedRfhn1QnKDbn+x4qKwM2LdMjU5GLKt3ZVTi6jYAunSRMuj3xuA9nRd1SUoZbs8OA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790175013; c=relaxed/simple; bh=puGRJbHE6IW3DYs6XE8fe9q+V9VWtEhJJZEOADFRmG8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WvZhIy5P2J90G08jvc8rM6OSmqPierzEb74/dCmKIKdLsL/vXrCMzOw9X9BD/mNCNAUgEe7OUw3tpm6WqezzWB8oy0G2mZ5dDoad7jTr+DcjEK38aSKq9X2dWQ8J1MtUsOA6jCyV62QkzMHdNwUYgT5CtfnBOC67u5VgCNUpd9w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=W7i/BXqd; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="W7i/BXqd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF3AD1F000FF; Wed, 23 Sep 2026 14:50:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790175012; bh=xcnAkMf1G+pcWCiwvq4vxHJfWpJ4ygMfDxBVy+0FrSQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=W7i/BXqd67l1N/AuyvzuvgCC9GDD0eRx+tq5uv8Y2v0TkvgjEkyr+WADxqE4oXapS 6f0i3Rk0S7p5mLW4AP5aKkSu8WCbDozKGA7dACRjCq/eqgl/1oPqGq7nEqpuZI2j/s kFwUOW67uDyjWZAGWyIMab2Dd6pDa3Z9YX3JZiPM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alexei Turtanov <9alexei9@gmail.com>, Dmitry Torokhov Subject: [PATCH 6.18 295/398] Input: atkbd - skip deactivate for Xiaomi Redmi Book Pro 16 2026 Date: Wed, 23 Sep 2026 16:06:09 +0200 Message-ID: <20260923140651.069955798@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260923140643.441954610@linuxfoundation.org> References: <20260923140643.441954610@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alexei Turtanov <9alexei9@gmail.com> commit aefbda23eeba234c3ff0f135dc5be6e294bd25a6 upstream. The internal keyboard of the Xiaomi Redmi Book Pro 16 2026 (board TM2425) does not work: atkbd_probe() succeeds and every command is ACKed, but no scancodes ever arrive afterwards. Testing on the hardware through serio_raw shows that ATKBD_CMD_RESET_DIS (0xF5) is the culprit. After 0xF5 the embedded controller keeps ACKing commands but stops delivering scancodes, and neither ATKBD_CMD_ENABLE (0xF4) nor ATKBD_CMD_RESET_BAT (0xFF) bring them back. Only re-enabling the keyboard interface at the controller level (i8042 command 0xAE, or rewriting the command byte as i8042_port_close() does) revives it. Running the init sequence without 0xF5 (0xED 0x00, 0xF3 0x00, 0xF4) keeps the keyboard working. 'i8042.dumbkbd=1' also works around this, but then the driver never writes to the keyboard and the LEDs cannot be controlled. Use the existing atkbd_deactivate_fixup quirk instead, as done for the sibling TM2424 by commit 3a046db33bb9 ("Input: atkbd - skip deactivate for Xiaomi Book Pro 14's internal keyboard"). Tested on v7.2: keyboard, Caps Lock LED and s2idle suspend/resume all work. DMI: XIAOMI REDMI Book Pro 16 2026/TM2425, BIOS RMAPT6B0P0909 05/22/2026 Fixes: 9cf6e24c9fbf ("Input: atkbd - do not skip atkbd_deactivate() when skipping ATKBD_CMD_GETID") Cc: stable@vger.kernel.org Signed-off-by: Alexei Turtanov <9alexei9@gmail.com> Link: https://patch.msgid.link/20260828112239.18081-1-9alexei9@gmail.com Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/keyboard/atkbd.c | 8 ++++++++ 1 file changed, 8 insertions(+) --- a/drivers/input/keyboard/atkbd.c +++ b/drivers/input/keyboard/atkbd.c @@ -1975,6 +1975,14 @@ static const struct dmi_system_id atkbd_ }, .callback = atkbd_deactivate_fixup, }, + { + /* Xiaomi Redmi Book Pro 16 2026 (TM2425) */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "XIAOMI"), + DMI_MATCH(DMI_PRODUCT_NAME, "REDMI Book Pro 16 2026"), + }, + .callback = atkbd_deactivate_fixup, + }, { } };