From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80880535FC3; Wed, 23 Sep 2026 14:52:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790175161; cv=none; b=VeWSj5q8NemNhfqlvyZyH8o0+Blfw/52yfCYPv1nBHyMsqk1LkmsQOXDjZPC7GunvKEUB+lzoZQaokXKAHoPlqKlIo6AAqOq11NsYtf+MpLA4QX9phGSSjn3u4xO+qW4pmODOXshVAC2hRHZaudyoU2OE6hEAo7hIGsQuu31FwE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790175161; c=relaxed/simple; bh=rS4XVTrEfA9vB3n3XSsTnbT5WWYAx5iR7x9oLDYFmTo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rgnUzUMYL4/oAfu1qsrNw/IGPGeIxXo2b9g5PfEONb7ZaBWMcrk+CU37mBEbJHTVFdJzyoLo4bTV+A49frrZogmusL2VvZ7gmq3VS7fKl8VDh0OF+8DbsryvI7RWLYh75FYRhRC/v8M8B/+1aKNLTqv0X3JYni0820INjD9JJ68= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lxsGWyby; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lxsGWyby" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AFD0E1F000FF; Wed, 23 Sep 2026 14:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790175157; bh=eG4CVCLDZQaslfpGWqUxUDC7v2f9CtNshta8RlGJE2Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=lxsGWybyl/yHn6nuIOGnsNE69iIhKNO5K9G3xTLZ208zIsiybHwmrsnvjNT9JoHil btxxbn3/pT3vPpK7UDaPyidCN9n5kptLySgDyt/N05kLtG7zrKGZPYYa15g1YBUEls yIhFOH2nbocV3WgXWk6jwJ8ZHYwUqpYfTV8wImtA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sashiko , Sajal Gupta , Ruben Wauters Subject: [PATCH 6.18 338/398] drm/gud: fix out-of-bounds write in gud_plane_atomic_check() Date: Wed, 23 Sep 2026 16:06:52 +0200 Message-ID: <20260923140652.185971597@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260923140643.441954610@linuxfoundation.org> References: <20260923140643.441954610@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sajal Gupta commit 59ced288fcba9e91bd38e61a972ad782c4edb7d0 upstream. The plane property loop uses req->properties[num_properties + i] as write index while simultaneously incrementing `num_properties` inside the loop. At iteration i, num_properties has also incremented by i, so the write is done at `initial_num_properties + 2*i`, skipping every other index and advancing by 2 per iteration. With just 2 connector and 32 plane properties the last write happens at index 64, one slot past the end of the 64-slot (indices 0–63) allocation. A USB device can trigger OOB by advertising the maximum number of properties. Fix by dropping the redundant `+ i`; num_properties is already the correct running index, as gud_connector_fill_properties() fills the preceding slots. Fixes: 40e1a70b4aed ("drm: Add GUD USB Display driver") Reported-by: Sashiko Link: https://sashiko.dev/#/patchset/20260821071812.16500-1-sajal2005gupta%40gmail.com?part=1 Signed-off-by: Sajal Gupta Cc: Acked-by: Ruben Wauters Signed-off-by: Ruben Wauters Link: https://patch.msgid.link/20260902123254.36987-1-sajal2005gupta@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/gud/gud_pipe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/gpu/drm/gud/gud_pipe.c +++ b/drivers/gpu/drm/gud/gud_pipe.c @@ -562,8 +562,8 @@ int gud_plane_atomic_check(struct drm_pl goto out; } - req->properties[num_properties + i].prop = cpu_to_le16(prop); - req->properties[num_properties + i].val = cpu_to_le64(val); + req->properties[num_properties].prop = cpu_to_le16(prop); + req->properties[num_properties].val = cpu_to_le64(val); num_properties++; }