From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB986488219; Wed, 23 Sep 2026 14:52:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790175167; cv=none; b=X/FGN3/+/WYs6112p2tsNqFhLqMILrSw6PM99yweestAyC6nZyQ9SN0nEfwXkfTtEeP3MPtU79BdAdZd3hJUYnCqFniZ2lA2E70ncOH2VzIWc8ADFf9XBBknhsDHSSZpNc8/8O/KwYIEELWG8KSHOXM7uhDPK2d9g8nob7brgIw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790175167; c=relaxed/simple; bh=MxdkB5hS1C+sBqfohl8DWZdDeq5iHUT3vCEc9hrSnv8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Fm0N1mNCPtOznxMTisKEO43t7GlNhDbHU13UniXyK5wGTb5VlGt5LcXW+VW7dK4y/awvAbPu1R6uD27SpsL+vfYj4XVQizOCmz9n/k+YQGgcnhQ95JWLXWB5mbrfoN3OQ/PNNzbc2DEPKKKmy0o7truATQtveKYmPEbjDG3YFmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=gK2CtwtH; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="gK2CtwtH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 056D81F00899; Wed, 23 Sep 2026 14:52:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790175163; bh=o9ghTWMzMYeQVUq1oBwCVqLDLZdtaHLtVnTOFmTb1Xc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=gK2CtwtHDBq65wjF3a80xrkJ5WTkNHTttTvNuXS401zEsBzZvxx17koMF3hu6R6aB QsrgTReGZH8/1qtlUdxLtBkINFiw65AyVaEl968FKSDbURM1CF9eInA12F4eQr92Oa t6/36CFgDf+JOvbd6g+B4PYu4TRRgdXdYbPa1zW0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guangshuo Li , Dmitry Baryshkov Subject: [PATCH 6.18 340/398] drm/msm/adreno: fix autosuspend cleanup during teardown Date: Wed, 23 Sep 2026 16:06:54 +0200 Message-ID: <20260923140652.241423651@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260923140643.441954610@linuxfoundation.org> References: <20260923140643.441954610@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guangshuo Li commit 6fbbf1e152f34ad3913e4a6476680aba672c5068 upstream. adreno_gpu_init() calls pm_runtime_use_autosuspend(), but adreno_gpu_cleanup() does not call the matching pm_runtime_dont_use_autosuspend() during teardown. If the autosuspend delay is set to a negative value while autosuspend is enabled, the runtime PM core increments usage_count to prevent runtime suspend. Without calling pm_runtime_dont_use_autosuspend() during teardown, this reference is not dropped and usage_count remains unbalanced. The documentation for pm_runtime_use_autosuspend() also notes that it is important to undo it with pm_runtime_dont_use_autosuspend() at driver exit time, unless runtime PM was initially enabled with devm_pm_runtime_enable(). Add the missing pm_runtime_dont_use_autosuspend() call to adreno_gpu_cleanup(). This issue was found by manual code inspection. Fixes: eeb754746b14 ("drm/msm/gpu: use pm-runtime") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Reviewed-by: Dmitry Baryshkov Patchwork: https://patchwork.freedesktop.org/patch/745110/ Link: https://lore.kernel.org/r/20260808131624.2854412-1-lgs201920130244@gmail.com Signed-off-by: Dmitry Baryshkov Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -1245,6 +1245,8 @@ void adreno_gpu_cleanup(struct adreno_gp for (i = 0; i < ARRAY_SIZE(adreno_gpu->info->fw); i++) release_firmware(adreno_gpu->fw[i]); + pm_runtime_dont_use_autosuspend(&gpu->pdev->dev); + if (priv && pm_runtime_enabled(&priv->gpu_pdev->dev)) pm_runtime_disable(&priv->gpu_pdev->dev);