From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8B8851993C; Wed, 30 Sep 2026 18:31:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790793085; cv=none; b=mdxYz9UfaHV1tH/67c7Cwllv6pj/+f3l8lpDM6hHAQLRqYRBrpY8XMB8SuU+O+E11CzvCAaAXrHmzR3gXFiEnB/80YNUcv3xLnvdSob7UTJreEOf+6I5aCGlHFXwb62SpxDFUCQ5VQnbzh7TwD0/aeX6E8NudKhJsBrYPkDLwVo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790793085; c=relaxed/simple; bh=Tc2laAc7CialPnWderj8ohA4OTOKYiRhZYIGr4rRanw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YkRwfODN/bVlHYEg0FMHyLjm4/3+l0mUJZx5F/lAAkTDgk4rsdyXvEY/TJEaNM9UegYqK3aVNHnhbl7ppBZcz+l9mLYYHHyhoklxnej/PRgVD07aiWNvAbuvB+wiyvM5FiuDduI+pgIqvPriH6cSsyhDQ1m9q4LhMrxXKiM08Eo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=oGKdn2v5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="oGKdn2v5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E8E91F000FF; Wed, 30 Sep 2026 18:31:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790793084; bh=ykUvz2vBAA7h8+VEAtkkN++xpXUZlbrRGlSf/gonNRk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=oGKdn2v5Tu573PIEKPnJ1THVFHHn2DCO4Uv295Uvv+WdIddrMH9svDBf3Nwdr+VdD TpkNar4GRzX+7OEZ/TEw8cGeK5z9He8OWvwbHAkPO/o9zBuu87za80KRshSyrLdE7T UNuXODZ+g5Qlj96iFMaXh6qnfsJX1ed3u8KdsWpc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, bui duc phuc , Simon Horman , Paolo Abeni , Sasha Levin Subject: [PATCH 6.18 123/395] net: ethernet: ti: netcp: fix pm_runtime usage counter leak on error Date: Wed, 30 Sep 2026 17:26:25 +0200 Message-ID: <20260930152343.311444582@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152340.591469096@linuxfoundation.org> References: <20260930152340.591469096@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: bui duc phuc [ Upstream commit ac4334522e4ba4a3b6710dd5d4cc98092824b8ca ] pm_runtime_get_sync() leaves the runtime PM usage counter incremented even when it fails, but the error path in netcp_probe() does not call pm_runtime_put_noidle() to balance it, leaking a reference each time resume fails. Use pm_runtime_resume_and_get() instead, which automatically drops the usage counter on failure, fixing the leak. Fixes: 84640e27f230 ("net: netcp: Add Keystone NetCP core ethernet driver") Signed-off-by: bui duc phuc Reviewed-by: Simon Horman Link: https://patch.msgid.link/20260918042804.13101-1-phucduc.bui@gmail.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/ethernet/ti/netcp_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c index 5ee13db568f08..269d81192089f 100644 --- a/drivers/net/ethernet/ti/netcp_core.c +++ b/drivers/net/ethernet/ti/netcp_core.c @@ -2167,7 +2167,7 @@ static int netcp_probe(struct platform_device *pdev) return -ENOMEM; pm_runtime_enable(&pdev->dev); - ret = pm_runtime_get_sync(&pdev->dev); + ret = pm_runtime_resume_and_get(&pdev->dev); if (ret < 0) { dev_err(dev, "Failed to enable NETCP power-domain\n"); pm_runtime_disable(&pdev->dev); -- 2.53.0