From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D6CB4E06CC; Wed, 30 Sep 2026 16:49:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790786962; cv=none; b=K2psAOsxLCQzX6lmxg8HSmecrDD5rBJ/O8YCv8q7zCL64D2FL55vKnXGedm1Fwko6YuGhiyJyb8ug6cQB7uZdbAa6xg/e5xKrpBSjxdTMHqhIdMLGvbLkSDxAMffL6FtdDahS4EpwmyjmnhsVOVPI10vO4+ASNtM515eXs9LnGQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790786962; c=relaxed/simple; bh=RHbYzYJxAnozexuIsy+GuBcYAB2DLbQ3bq/d+OU2sQc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BmvvYD5zvppznXYU521NIdtp3vsNtzucqkOz/1hpxeUkY5U4Z/h98SRTkfpI+npourDBZWyypls6e5xeJn2lFdBYDkGs5yILCPbepe4HsvCsmONhh9/3CrDipzMmbDJxL9vcCkTHDH5n52UzJOtAntCWhGnQJ8Y/swVBuxAXdiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Y9GLtcHU; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Y9GLtcHU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D67991F00893; Wed, 30 Sep 2026 16:49:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790786961; bh=fymW+JqZ3als4ocBu/OK8gJBrLB+YEyBnJPZfq0JpJ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Y9GLtcHUyAav38Seh1ozCIHXvBmUgq4YkGIwYtoF198o2ClbjnA2+m2EUp2LEOb7U kT8HwUa2wIwL9qjZ0BHNiX6DKHpENQ5QiO0vjzWfo49uyRNEtnI8kUdTQx3PUajtZP XvvwbPsLknHJqg5sgvipCJEOPPA4okqWzLpF7zu8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jiayuan Chen , Eduard Zingerman , Alexei Starovoitov , Sasha Levin Subject: [PATCH 7.2 018/457] bpf: Fix divide-by-zero in btf_struct_walk() Date: Wed, 30 Sep 2026 17:22:03 +0200 Message-ID: <20260930152346.422130666@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152346.024115587@linuxfoundation.org> References: <20260930152346.024115587@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jiayuan Chen [ Upstream commit b0b3dc66529676228cb938cbcad66920f735c223 ] When an access goes past the struct and the last member is a flexible array, btf_struct_walk() folds the offset back into a single element with (off - moff) % t->size, but never checks that the element type has a size. BTF takes an empty struct, so this in program BTF /* event could be empty */ struct event { #ifdef HAVE_TIMESTAMP __u64 ts; #endif }; struct batch { int nr; struct event events[]; }; divides by zero at prog load time. Getting there needs a PTR_TO_BTF_ID that is not MEM_ALLOC, e.g. a plain read of a local kptr stashed in a map from a sleepable program. Oops: divide error: 0000 [#1] SMP KASAN PTI RIP: 0010:btf_struct_walk+0x53f/0x1570 Call Trace: btf_struct_access+0x42a/0xcd0 check_ptr_to_btf_access+0x4dc/0x1160 check_mem_access+0x3a45/0x8740 check_load_mem+0x36a/0xd10 do_check_common+0x3ef0/0xb210 bpf_check+0x6d3b/0x8580 bpf_prog_load+0xf7c/0x2720 __sys_bpf+0xa83/0x3690 __x64_sys_bpf+0xc7/0x150 x64_sys_call+0x1f3f/0x27e0 do_syscall_64+0xe5/0x610 entry_SYSCALL_64_after_hwframe+0x76/0x7e Reject a zero-sized element type. The fixed array path in the same function already bails out on the same thing: btf_struct_walk() ... /* skip empty array */ if (moff == mtrue_end) continue; msize /= total_nelems; Fixes: 9c5f8a1008a1 ("bpf: Support variable length array in tracing programs") Signed-off-by: Jiayuan Chen Acked-by: Eduard Zingerman Link: https://lore.kernel.org/r/20260910122316.186384-1-jiayuan.chen@linux.dev Signed-off-by: Alexei Starovoitov Signed-off-by: Sasha Levin --- kernel/bpf/btf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c index 022d5a594dc95..ea3d50c99ec22 100644 --- a/kernel/bpf/btf.c +++ b/kernel/bpf/btf.c @@ -7191,7 +7191,7 @@ static int btf_struct_walk(struct bpf_verifier_log *log, const struct btf *btf, if (btf_type_is_int(t)) return WALK_SCALAR; - if (!btf_type_is_struct(t)) + if (!btf_type_is_struct(t) || !t->size) goto error; off = (off - moff) % t->size; -- 2.53.0