From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26DDD514753; Wed, 30 Sep 2026 18:38:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790793516; cv=none; b=e+3STVAF/mmtIhzFHVq19LMVI3KGXz0SToRFdVNAI+V0aNNaG/cO0w50ALpyYKv9ZVJjeu4a31iHn5FFJRb0voKrVxTh9g+Msb8JjP7Tcpqplr/UVoaisDSJLKVR+2lPrqfe/IX81nufHrmrggsjs5+pBeXoM9VP/tx7l3j1vWM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790793516; c=relaxed/simple; bh=Z8sapW5/13zpZ7/VsslZcQg44nhEoPMgBQ5ozIEdkD8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VdkW8eLF3YAD9Nn6EMeSCF8/a6FubWSmVIUbhPkthYLgN+gU8vpqgpA8XPJHd2RrjERoMfN710PE1Rr+iOi1sadhF3hr2aKYrW9NUr3hqI70l9NScF75b9qIWB2e5j2LHCB7ZbONrk6wGJHMEEmta6gx7Sfi1/AIBxyHxtxJkOE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=clC6IKJS; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="clC6IKJS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3226C1F000FF; Wed, 30 Sep 2026 18:38:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790793514; bh=4Thjt70vFKa3RGX9lyZQz+wEgIipK425fjkdCprK8pk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=clC6IKJSNq8F6sYVVDmyDLzAHBM0Ip6xnmVj5QBn44efVo7V1PV9FWiDDtw/WRJpH 8W/+Ymfn4kd+RRwfm896b4Esm9etPS+QdrW340f0cm9VgbXgpk6l5XuRKYgQ3NWqxz 7TGV0dJ29dKf4VT2w++Ih6kLYIgW/PWpmKfQCmAY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Fourie Zhang , Nikolay Aleksandrov , Jakub Kicinski Subject: [PATCH 6.18 283/395] net: bridge: mdb: restart port group walk after deletion Date: Wed, 30 Sep 2026 17:29:05 +0200 Message-ID: <20260930152346.798814377@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152340.591469096@linuxfoundation.org> References: <20260930152340.591469096@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fourie Zhang commit ab1404ac81154a89fb61ac50ae9a04cd8d4834dc upstream. br_mdb_flush_pgs() keeps a pointer-to-pointer cursor while walking mp->ports. br_multicast_del_pg() can re-enter the same MDB entry through br_multicast_sg_del_exclude_ports() and unlink other port groups. If the cursor points into one of those groups, the next iteration dereferences a stale cursor and can leave mp->ports pointing at freed memory. A following RTM_GETMDB exposes the dangling pointer: BUG: KASAN: slab-use-after-free in br_mdb_dump Read of size 8 br_mdb_dump rtnl_mdb_dump rtnl_dumpit netlink_dump Reset the cursor to mp->ports after every deletion. The deletion removes at least the selected group, so the restarted walk always makes progress. Fixes: a6acb535afb2 ("bridge: mdb: Add MDB bulk deletion support") Cc: stable@vger.kernel.org Signed-off-by: Fourie Zhang Acked-by: Nikolay Aleksandrov Link: https://patch.msgid.link/20260920110852.60293-1-fouriezhang@tencent.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/bridge/br_mdb.c | 2 ++ 1 file changed, 2 insertions(+) --- a/net/bridge/br_mdb.c +++ b/net/bridge/br_mdb.c @@ -1523,6 +1523,8 @@ static void br_mdb_flush_pgs(struct net_ } br_multicast_del_pg(mp, p, pp); + /* br_multicast_del_pg() can remove other groups from this list. */ + pp = &mp->ports; } }