From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 805EB50B43D; Wed, 30 Sep 2026 15:35:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790782514; cv=none; b=FRPjLJ4f9haAY1CWTXwF2sLZI4YnN5kqRwyA7Y03ErfTDkKp/y2cfg1TN9Uus/ZalWnOCflWOaTjP+u/8SrGv8r/5DZiXPyjd/VBJgstuJPJpuE18jGYO3o7YDj2EuJ33emsDV8X0QLb9BxzjadI9QLbqiiF3IXJyzxfwyk5Mw8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790782514; c=relaxed/simple; bh=EAOfewgs0RjXyQ3ZYkVh+aK1ZFcyoSHFJHMasfPi1eE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AoCNoQDrD3kNW6fOCIF+X+Vz3R57OhgqlaQ2kp2AUklS9Ed+Z6JjP05bh/pSegz48JanmDTKubYYxLr1PtAIPB4OcYiPv8Jtu7Kc7u+mTvfYuKFwZg4JahcukF5aekRQrvNe0z0TSTXMogJc4cangeuD9POU0Yp4W+jkE1FXfqQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OIg/dAIu; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OIg/dAIu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 557611F00893; Wed, 30 Sep 2026 15:35:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790782501; bh=hb30ZHxCDiPvB46P7lkvvxdIiUKcTa1LOQIrX0v8q8U=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=OIg/dAIum831wBZcTQLR7cXKaWLqvgH/bCDmW2LygfuriFfPUPA9EFIDlJMjh5SCa 1tvB2xAlvu4FUf2Haz5KLbgmN8guVoAvUUETk+nH5lUzaIDA4l20c7713OtR0tr8TD qvpSVJctvGuBAhTfkolAxRLaejdJ4HrfFQAf7maY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kumar Meiyappan , Sagar Biradar , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.10 024/595] scsi: pm8001: Reject firmware update in fatal error state Date: Wed, 30 Sep 2026 17:18:37 +0200 Message-ID: <20260930152348.245563459@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kumar Meiyappan [ Upstream commit 2a8fbcfb04aa9db189bfa3842d4f586aecd0e631 ] pm8001_store_update_fw() allows a firmware update request even when the controller has already entered a fatal error state. Firmware update is not valid once the controller is in that state, and attempting it can lead to a call trace. Reject the request early by checking controller_fatal_error, set the firmware status to FAIL_PARAMETERS, and return -EINVAL. Signed-off-by: Kumar Meiyappan Signed-off-by: Sagar Biradar Link: https://patch.msgid.link/20260416153757.414896-1-sagar.biradar@microchip.com Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/pm8001/pm8001_ctl.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c index 467f77664efb9..8101d9463ca55 100644 --- a/drivers/scsi/pm8001/pm8001_ctl.c +++ b/drivers/scsi/pm8001/pm8001_ctl.c @@ -822,6 +822,14 @@ static ssize_t pm8001_store_update_fw(struct device *cdev, goto out; } + if (pm8001_ha->controller_fatal_error) { + pm8001_dbg(pm8001_ha, FAIL, + "controller in fatal error state, firmware update rejected\n"); + pm8001_ha->fw_status = FAIL_PARAMETERS; + ret = -EINVAL; + goto out; + } + for (i = 0; flash_command_table[i].code != FLASH_CMD_NONE; i++) { if (!memcmp(flash_command_table[i].command, cmd_ptr, strlen(cmd_ptr))) { -- 2.53.0