From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AC6D4F93A8; Wed, 30 Sep 2026 16:52:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790787167; cv=none; b=uXNxKZslMKkvZUf+Z9cVCcYeEP/d55Ax+/HISfGkxvQe5xjiiysm/R4N3+Ca4o6Ibsa7xnnJcGqhfZp20ZFi1aDykPewKpgGvKTSmzhL54Y/9xatK266U78LTU1V1OX3fIXWpkonWnkpNVqAHq+3X82YB8ceyEFrMXwSxo2CpRk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790787167; c=relaxed/simple; bh=MkByhk3lvte2J47Mq+g/wLN0iy1WVLVAQc9254sWGaQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=au/tDJ4EcwWJUF81OLaAIqM164P/xQEjYUJk9m8+l4qFg/A8RD9ZLVENAK+tTiyP+lulyAxzJbO/wy6NtYGTGhfh8lsXtEQR7nm0WVeg8DSWLzP2docdaor/dk/xnk3CuhtsbVHclZ2Pn97nVKVHx0PtctZajS2ZXfziYyNaHYY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=yCKLZD77; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="yCKLZD77" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C7061F00899; Wed, 30 Sep 2026 16:52:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790787166; bh=1+vmpBzOU+FDiGbu5PKAkKvUXJCwH/yO5s8HYbyezGg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=yCKLZD779UmHcufHhgJ9JhU6t2HKgjhTWpTfeMq+MZsSj8r7tlw6xvM4TsbSIaEDw guvqNflMgtJj1SCplcsytGnqy3YLaKfCf24ES8HstMzjspISYL4/GOmIOkjIfg9mm9 WuBv+iFjVuY06Y5klx4ccXLWn+Uavki7pVhftnko= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuhao Jiang , Junrui Luo , Dmitry Osipenko , Sasha Levin Subject: [PATCH 7.2 108/457] drm/virtio: fix object leak when drm_gem_handle_create() fails Date: Wed, 30 Sep 2026 17:23:33 +0200 Message-ID: <20260930152348.384741762@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152346.024115587@linuxfoundation.org> References: <20260930152346.024115587@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Junrui Luo [ Upstream commit 36570ef2244cc4d7563b1f0157bc0f032498638c ] virtio_gpu_gem_create() owns the reference taken by virtio_gpu_object_create(). On the drm_gem_handle_create() error path it calls drm_gem_object_release() instead of dropping that reference. drm_gem_object_release() is the inverse of drm_gem_object_init() and does not touch the reference count or call obj->funcs->free(), so it is only correct as the last step of a destructor, as in virtio_gpu_cleanup_object(). Using it here leaves the bo at refcount 1 with no remaining reference, so virtio_gpu_free_object() never runs and the shmem pages, sg table and virtio_gpu_object are leaked. Since virtio_gpu_object_create() has already set bo->created, VIRTIO_GPU_CMD_RESOURCE_UNREF is not queued either, leaking the host-side resource and the resource id. drm_gem_handle_create_tail() drops the handle reference on all of its internal error paths, so the caller only has to drop its own. Use drm_gem_object_put(), matching the success path below. Fixes: dc5698e80cf7 ("Add virtio gpu driver.") Reported-by: Yuhao Jiang Assisted-by: Claude:claude-opus-5 Signed-off-by: Junrui Luo Signed-off-by: Dmitry Osipenko Link: https://patch.msgid.link/20260915-fixes-v2-1-a0d799e4db66@outlook.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/virtio/virtgpu_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_gem.c b/drivers/gpu/drm/virtio/virtgpu_gem.c index 66c3f6f74e9c6..d2f0b8a3f172b 100644 --- a/drivers/gpu/drm/virtio/virtgpu_gem.c +++ b/drivers/gpu/drm/virtio/virtgpu_gem.c @@ -45,7 +45,7 @@ static int virtio_gpu_gem_create(struct drm_file *file, ret = drm_gem_handle_create(file, &obj->base.base, &handle); if (ret) { - drm_gem_object_release(&obj->base.base); + drm_gem_object_put(&obj->base.base); return ret; } -- 2.53.0