From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8896C4E4333; Wed, 30 Sep 2026 15:34:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790782496; cv=none; b=Cw0V7VC8mT1VymTbTOWZWp39jRm4GhLDUGBdFTcR0uovWnOhJVracnA6GSSpmHRdhcmJkOZOZHRObZds/jdEtUXmPwdVfYGTFkty2E/wfvIai2uYnu0EqtvijBB4uqemOkYhDwJBLkqNwTTUBbVW851lHWuZzJwK9fIbO5WNzj4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790782496; c=relaxed/simple; bh=Hou2ilGxraXA3KBH8T5cvo5SagKgGX0TtaEnM1GOwvI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oaBRrEUfAh3WcoJhSHqPBPcmR1YvgIWnUdq+GA1l7Iaj1l5d26xA/2GgOEtydVP0qJaY9EbxuFED9LHuXV65qqZ6sfZQozJQgkJm8/5GhkAA2UGWsANT5wW53h/GIrSXl1URfW9RUcxCSWGtVd+9YJAC4Aw9u4KLzGqUS32SfYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bduIckgZ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bduIckgZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CF521F000FF; Wed, 30 Sep 2026 15:34:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790782479; bh=bq7Y4+saUXDKIAJw/FNZbROwndK1Yz0KIJrkXyuTxbY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bduIckgZXp2+B5ao4kCQMMfFxnHW+UCcqVS1fMNnTyVhT9SmthB4eGGZdbkVwcnhN sl5PpiIPLQXs5Sm4Rt4gE655H6RX28gTu/iXlGmYqvQau3XIXieKrzZ6ocOURcpAAY 4JxvtRhHdrquZV91cSUFLhtAL+1Z6qk7bn3c4bMk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Christian Borntraeger , Heiko Carstens , Alexander Gordeev , Sasha Levin Subject: [PATCH 5.10 059/595] s390/zcore: Removed unused variables Date: Wed, 30 Sep 2026 17:19:12 +0200 Message-ID: <20260930152349.003972416@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Heiko Carstens [ Upstream commit 0a2aa995c0a1d363b5f0803862e84834e3876ae2 ] allmodconfig with clang W=1 points out unused global variables: drivers/s390/char/zcore.c:49:23: error: variable 'zcore_reipl_file' set but not used [-Werror,-Wunused-but-set-global] drivers/s390/char/zcore.c:50:23: error: variable 'zcore_hsa_file' set but not used [-Werror,-Wunused-but-set-global] Remove both of them, since there is no point in keeping them. Reviewed-by: Christian Borntraeger Signed-off-by: Heiko Carstens Signed-off-by: Alexander Gordeev Signed-off-by: Sasha Levin --- drivers/s390/char/zcore.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/s390/char/zcore.c b/drivers/s390/char/zcore.c index 1aee6b2ae66fb..baea531c990fe 100644 --- a/drivers/s390/char/zcore.c +++ b/drivers/s390/char/zcore.c @@ -45,8 +45,6 @@ struct ipib_info { static struct debug_info *zcore_dbf; static int hsa_available; static struct dentry *zcore_dir; -static struct dentry *zcore_reipl_file; -static struct dentry *zcore_hsa_file; static struct ipl_parameter_block *zcore_ipl_block; static DEFINE_MUTEX(hsa_buf_mutex); @@ -325,10 +323,8 @@ static int __init zcore_init(void) goto fail; zcore_dir = debugfs_create_dir("zcore" , NULL); - zcore_reipl_file = debugfs_create_file("reipl", S_IRUSR, zcore_dir, - NULL, &zcore_reipl_fops); - zcore_hsa_file = debugfs_create_file("hsa", S_IRUSR|S_IWUSR, zcore_dir, - NULL, &zcore_hsa_fops); + debugfs_create_file("reipl", S_IRUSR, zcore_dir, NULL, &zcore_reipl_fops); + debugfs_create_file("hsa", S_IRUSR|S_IWUSR, zcore_dir, NULL, &zcore_hsa_fops); register_reboot_notifier(&zcore_reboot_notifier); atomic_notifier_chain_register(&panic_notifier_list, &zcore_on_panic_notifier); -- 2.53.0