From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D85874F3EB8; Wed, 30 Sep 2026 15:35:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790782565; cv=none; b=d+GZ6ktMEkkbyVET80Is0aofhKIj8PdcZvK9pXJSmbuw3weRNr03Z+JwE9s3UZIXUj456facWJP7jWXPISmOcFOW3o2Xc/Sn5sm2ARBWhNGw/Xtr2P288TnCPFx40abluogjxUY13TkzEkiv07NbphHjNXSrIgouBYB9xuM4H+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790782565; c=relaxed/simple; bh=oJfohvgviaP7+9cUvCS26tjgLQqKmZPn+GIomzJJNZ4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iSlth1grbLYlyTM4AcMC0+h4fE3wV1GOzK9+tbmVeJ+kg5MudinmtD6RFmTzxNn17IFOHaLDvfsGdmMlbiCtdCgT+KkbDMLEFdD0cqKoaB62ZMtc458JWxexhx9LQjGStoUb1K2fD30Blc1vVpga1khmXD7bUEahAuDb5Cgjcu0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=pswH2JWB; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="pswH2JWB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E9671F00898; Wed, 30 Sep 2026 15:35:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790782555; bh=Sjglv/JAgMqvmrk2eI9Fh8rEudvdyZ0pQ99//vQ3GRQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=pswH2JWBVhhjPTOQ8Hszx3uNRAnhS0IO1voQZ3T1s7Xn/zFNeqdEke3uglzZS8WcU nDiX/hc4ujaFtr+u0wr0sD86heBRScgz+/Pke/Zlh5wrNjrEjQMY8gJIhJDJRRLaI+ uPrOWpR7feBnDIIB5DNnF6FA8FhcEs7Bo3D5SocA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sanjay Chitroda , Jonathan Cameron , Sasha Levin Subject: [PATCH 5.10 088/595] iio: accel: mma8452: switch to non-devm request_threaded_irq() Date: Wed, 30 Sep 2026 17:19:41 +0200 Message-ID: <20260930152349.632534071@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sanjay Chitroda [ Upstream commit 0a6726ec20cd4c0101f2de0ca485a11676224dea ] Avoid using devm_request_threaded_irq() as the driver requires explicit error-handling path(s). Using devm_* API together with goto-based unwinding breaks the expected LIFO resource release model. Add explicit IRQ cleanup in the driver teardown paths to follow kernel resource management conventions. Signed-off-by: Sanjay Chitroda Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/accel/mma8452.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index b8ab2b0627a3c..a8a145f818d8a 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -1676,18 +1676,16 @@ static int mma8452_probe(struct i2c_client *client, goto trigger_cleanup; if (client->irq) { - ret = devm_request_threaded_irq(&client->dev, - client->irq, - NULL, mma8452_interrupt, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, - client->name, indio_dev); + ret = request_threaded_irq(client->irq, NULL, mma8452_interrupt, + IRQF_TRIGGER_LOW | IRQF_ONESHOT, + client->name, indio_dev); if (ret) goto buffer_cleanup; } ret = pm_runtime_set_active(&client->dev); if (ret < 0) - goto buffer_cleanup; + goto free_irq; pm_runtime_enable(&client->dev); pm_runtime_set_autosuspend_delay(&client->dev, @@ -1696,7 +1694,7 @@ static int mma8452_probe(struct i2c_client *client, ret = iio_device_register(indio_dev); if (ret < 0) - goto buffer_cleanup; + goto free_irq; ret = mma8452_set_freefall_mode(data, false); if (ret < 0) @@ -1707,6 +1705,10 @@ static int mma8452_probe(struct i2c_client *client, unregister_device: iio_device_unregister(indio_dev); +free_irq: + if (client->irq) + free_irq(client->irq, indio_dev); + buffer_cleanup: iio_triggered_buffer_cleanup(indio_dev); @@ -1733,6 +1735,9 @@ static int mma8452_remove(struct i2c_client *client) pm_runtime_set_suspended(&client->dev); pm_runtime_put_noidle(&client->dev); + if (client->irq) + free_irq(client->irq, indio_dev); + iio_triggered_buffer_cleanup(indio_dev); mma8452_trigger_cleanup(indio_dev); mma8452_standby(iio_priv(indio_dev)); -- 2.53.0