From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FDB01E0DD8; Wed, 30 Sep 2026 16:58:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790787501; cv=none; b=i4u2EoecQ7IgIn+D3r6BDyDhEIXdY2n5oKw64vWbstXCx1jzPcgp198BD3TqGhjDuU6ESt/M2rS+VQSmc9N7kZrjp3U7FpZPEBDR00nY0JKofH21CZbdBKRjfoQyV/sq+n09/ChcRgJY1u27kcZRss0jD4P/nKw1BxShGtpoFwE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790787501; c=relaxed/simple; bh=0wIhG0Rb8aweq5+ruxfm2R5ODOQsbLup/rUOOnvInMg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gonN5OUMMhZmlQmnEnOheygCU7Z+Vv6j1IaDmo7NPFhrpawXIKUmGi3op7371Vtqs3DtzzadrhmyZnv1SclAg1J30QJ0vmdMWPDXoxkGhUNYkSSAk8O1jjRg7IDmCYSMyvV+yTtSELo6jgQDA2wegsmoR8/XjiLVASsYtT8Y1XU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=HoI31D0E; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="HoI31D0E" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3110B1F0089C; Wed, 30 Sep 2026 16:58:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790787499; bh=tMB1gHB/pWDj6y0qinyqOJHngrkHXHztD+BRQp4yZes=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=HoI31D0EDyyEMn+jNJa0N8IowUs3L0DfJyks8nNRcdU4xetrDPYzNSAwbbrpezdTr tcERoTserwuK8uzZK1hVx0mp6qsk5j3kdcizI7dHJPl+PU1k/psF+1OI1R5TBcGG8C Bt5vf7dGkm6g3U30dJ/aXlBfPkVi9+aBuam9WiK0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Aleksei Sviridkin , Jakub Kicinski , Sasha Levin Subject: [PATCH 7.2 207/457] net: dsa: mt7530: fix NULL dereference on unbind of MT7531 and MT7621 Date: Wed, 30 Sep 2026 17:25:12 +0200 Message-ID: <20260930152350.520607846@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152346.024115587@linuxfoundation.org> References: <20260930152346.024115587@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Aleksei Sviridkin [ Upstream commit c2cdef41e0b4d8ed23a5b41e6ad4e64594e055e4 ] The core and io supplies are only requested for ID_MT7530: both the devm_regulator_get() in probe and the regulator_enable() in mt7530_setup() are guarded by the switch id, but mt7530_remove() disables them unconditionally. On an MT7621 or an MT7531 both pointers are still NULL from devm_kzalloc(), so rmmod or a sysfs unbind calls regulator_disable() on NULL. Fixes: ddda1ac116c8 ("net: dsa: mt7530: support the 7530 switch on the Mediatek MT7621 SoC") Signed-off-by: Aleksei Sviridkin Link: https://patch.msgid.link/20260918015020.2518315-2-f@lex.la Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/dsa/mt7530-mdio.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/net/dsa/mt7530-mdio.c b/drivers/net/dsa/mt7530-mdio.c index 784dd58a71589..de42f70afcfa1 100644 --- a/drivers/net/dsa/mt7530-mdio.c +++ b/drivers/net/dsa/mt7530-mdio.c @@ -227,15 +227,17 @@ mt7530_remove(struct mdio_device *mdiodev) if (!priv) return; - ret = regulator_disable(priv->core_pwr); - if (ret < 0) - dev_err(priv->dev, - "Failed to disable core power: %d\n", ret); - - ret = regulator_disable(priv->io_pwr); - if (ret < 0) - dev_err(priv->dev, "Failed to disable io pwr: %d\n", - ret); + if (priv->id == ID_MT7530) { + ret = regulator_disable(priv->core_pwr); + if (ret < 0) + dev_err(priv->dev, + "Failed to disable core power: %d\n", ret); + + ret = regulator_disable(priv->io_pwr); + if (ret < 0) + dev_err(priv->dev, "Failed to disable io pwr: %d\n", + ret); + } mt7530_remove_common(priv); -- 2.53.0