From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D235B511E9B; Wed, 30 Sep 2026 16:56:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790787421; cv=none; b=RBjTeIe194+KdWqHPNA2mHnnZtc0yp/vgeFBw4WJ/4adIxzYr/InSaOjPN4SWQ867to4SQm6cT7f/qkr70YPctPd2t/FAwdMjdafjHcceIHyLxVXaxXrqg5qweGi+FEXUWFD7Eqp0vrwyzwLo5PoGPPE9zER2omZxI52FT9QxmM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790787421; c=relaxed/simple; bh=Eob14kY/S6SYezrGesZT2r8S+J73dvsN1fyGdbnv/6s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ERJZ+sHAxyjxtsJ0JQTCSEkEYLLsh3KOETrIsX8gC/WST7hFSTA6pYP3Tpqp2cMrE5a35iVi783neDjzL9Q1jQLZyFkuvXYlcn4s5TrsRpGuSP7w7qKP3JFFxERA78mXdhpqVzobq315z1uYvnsOqGCc+09GnasyPjeAGYz+gMA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=SCbCrH2r; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="SCbCrH2r" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 306471F000FF; Wed, 30 Sep 2026 16:56:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790787419; bh=ZPmVgKCw5wQ6ANPM4AEuL/seVzLwq3SGJLcqKmxrWdY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=SCbCrH2r4DhZpoTTZu/fwmrDCjin7nnNnFLq1Ly9H0DjS37GH+O27JYmJzlMqttCS eaIpsPVZ3ly+j56rCrRunPeFlyh5BGAowjRbJhdivN5Gbku+1MJt6HoR4ft0OZtDNy y97FwgHh3n+6CrV6t5agRtE3Ag5P9jNaOGVQGWPc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jamal Hadi Salim , Jiri Pirko , Eric Dumazet , Jakub Kicinski , Sasha Levin Subject: [PATCH 7.2 224/457] net/sched: sch_teql: fix shadowed err in __teql_resolve() Date: Wed, 30 Sep 2026 17:25:29 +0200 Message-ID: <20260930152350.885016066@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152346.024115587@linuxfoundation.org> References: <20260930152346.024115587@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Dumazet [ Upstream commit 907b978e82cb4c1c245fc2985bb27c5d5c88c8f6 ] __teql_resolve() declares an inner 'int err;' inside the 'if (neigh_event_send(n, skb_res) == 0)' block, shadowing the outer 'int err = 0;'. As a result, a negative return from dev_hard_header() is written to the inner variable and __teql_resolve() still returns 0. Remove the shadowed variable and set the outer err to -EINVAL when dev_hard_header() returns a negative error. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Closes: https://lore.kernel.org/netdev/179022851638.2160803.1808206741379444999@kernel.org/ Cc: Jamal Hadi Salim Cc: Jiri Pirko Signed-off-by: Eric Dumazet Link: https://patch.msgid.link/20260924082951.1599377-4-edumazet@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/sched/sch_teql.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/net/sched/sch_teql.c b/net/sched/sch_teql.c index 9e52afc2d9808..409ce50cc0dbc 100644 --- a/net/sched/sch_teql.c +++ b/net/sched/sch_teql.c @@ -265,14 +265,11 @@ __teql_resolve(struct sk_buff *skb, struct sk_buff *skb_res, } if (neigh_event_send(n, skb_res) == 0) { - int err; char haddr[MAX_ADDR_LEN]; neigh_ha_snapshot(haddr, n, dev); - err = dev_hard_header(skb, dev, ntohs(skb_protocol(skb, false)), - haddr, NULL, skb->len); - - if (err < 0) + if (dev_hard_header(skb, dev, ntohs(skb_protocol(skb, false)), + haddr, NULL, skb->len) < 0) err = -EINVAL; } else { err = (skb_res == NULL) ? -EAGAIN : 1; -- 2.53.0