From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 417724F93B9; Wed, 30 Sep 2026 15:40:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790782856; cv=none; b=oQKtmGf+HvTPjKraSem8xHBkDkGd1qdDikVF1hTTAaT9RRbtu92krv4QHpj3vCoYqQbDl3ItG3Ttuxaknb5E26oe5w61RyQmpk/pV01XNvH/TKAlNYmhlDqN/wvg+8dfYzHRO4G0pFruMOW/mQiqq4vMqmRmbqZQqYbnKdqnsDQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790782856; c=relaxed/simple; bh=BynhcvMOKI2mUnViRhX1aPVJcjfcO9NJWczHmD//SgY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WiLizTNTbwafrRbEDgSLNx4hTds65Mn+MmzEdIID+lTLWAoUOoiVGMQ/WZJVMURH+bOFUFeissvzTC5G+Qz4lFgtP/AoZcE+h+fXMY1DFgup4adDGWT871XceObwKj4Sij8O4i6SK1s5SJSdRZCegLL4t7+ItEQ+KVQL1J559t0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=dlBSSh1p; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dlBSSh1p" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 307891F000FF; Wed, 30 Sep 2026 15:40:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790782848; bh=zY1MmYXC+/PziZoDwkCz7wUAY1d0J4PUPNM3Av36w88=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=dlBSSh1pSpfQfOjMiynX1yCR2Tkb36MxIZdc0MFK17l+NU4D2/xrcrW4b+T9waHRc vDiOQeufHxNIqF+HdD+WbblVPpJ4eZ9Slz7BBKO/z/r46zJ+Wy6FeTjRWEA+KgALUO C2wxyvIeaDM7gAc1dlbsBxt6c/7T+GBzw2v0vQ+Y= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jad Keskes , "Borislav Petkov (AMD)" , Sasha Levin Subject: [PATCH 5.10 190/595] EDAC/device_sysfs: Use kstrtouint() for poll_msec to prevent truncation Date: Wed, 30 Sep 2026 17:21:23 +0200 Message-ID: <20260930152351.827699986@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jad Keskes [ Upstream commit 66cc9dec919dd63d8e4b3d386f7aed3ae684e645 ] The poll_msec sysfs store file uses simple_strtoul() which accepts an unsigned long, but the target field (poll_msec) is unsigned int. On 64-bit systems, a value > UINT_MAX is silently truncated when stored. Fix the mismatch by using kstrtouint() instead. This rejects values larger than UINT_MAX at parse time, making truncation impossible. Also add a check for value < 1 to reject the 0-delay case, which would cause the poll work to spin without delay and consume 100% CPU. Fixes: e27e3dac6517 ("drivers/edac: add edac_device class") Signed-off-by: Jad Keskes Signed-off-by: Borislav Petkov (AMD) Link: https://patch.msgid.link/20260730145549.148229-1-inasj268@gmail.com Signed-off-by: Sasha Levin --- drivers/edac/edac_device_sysfs.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/edac/edac_device_sysfs.c b/drivers/edac/edac_device_sysfs.c index 5e75937537997..b943223691164 100644 --- a/drivers/edac/edac_device_sysfs.c +++ b/drivers/edac/edac_device_sysfs.c @@ -90,14 +90,21 @@ static ssize_t edac_device_ctl_poll_msec_store(struct edac_device_ctl_info *ctl_info, const char *data, size_t count) { - unsigned long value; + unsigned int value; + int ret; /* get the value and enforce that it is non-zero, must be at least * one millisecond for the delay period, between scans * Then cancel last outstanding delay for the work request * and set a new one. */ - value = simple_strtoul(data, NULL, 0); + ret = kstrtouint(data, 0, &value); + if (ret < 0) + return ret; + + if (value < 1) + return -EINVAL; + edac_device_reset_delay_period(ctl_info, value); return count; -- 2.53.0