From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DACC4F3EAA; Wed, 30 Sep 2026 17:01:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790787716; cv=none; b=W65JKxhjp8Bz/FZuRgzB5fkfl/J3V/nKnZaeOQUWtjNNohwzlcoXCCTK+HatEiDhQfR6HobRDNsrQrmlcgZr5QzARfNPYc0lmHUFBpQqC1lvjvFLQrQToJdpjF1EKSHG3HXaq+1VcrSNEvF9OrO60z7GygaBT1qROAdmIQ44rqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790787716; c=relaxed/simple; bh=HLlrBlBpqZsat1RLsL4nQlO0HQe1LzXQ36ntX4TtT80=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iOZoHk8xJzog6y3MmxJcDd6qjXz/tttGX2gUPi55PcmsqulFkOR+ZjU+u7P2qKKP7K93J4rnadRsCFADND1TxnBfHE932tOR+DcQXS2Fufu99+WzWZGdm91Tn/r88WQCzeiEmNvuUXEJq736raj3Dv0Mugnst6oCYLd20ejEl5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=juuBHbqZ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="juuBHbqZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA1DA1F00898; Wed, 30 Sep 2026 17:01:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790787715; bh=me/2rRN/8THd05PV1mINH47Lzs3Q9gvG9FNiWCG9rtc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=juuBHbqZoeWRsGhGjXFtoFiFiJTppWfv8kMmShXFISEd5iHA+srege0J801/khsyn ndhWgcghxpHiBY8e8f1GZiypmDl8YCJHw5fYu5ufxCrOYpJsjEpTYXyPIvu+8AzMgK Seh9ii1j4bLOJNHjSEa06iL2zkebPiPWB0gPCl3E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wentao Liang , Tariq Toukan , Jakub Kicinski Subject: [PATCH 7.2 327/457] net/mlx5: Fix rev_entry reference leak in mlx5_tc_ct_shared_counter_get() Date: Wed, 30 Sep 2026 17:27:12 +0200 Message-ID: <20260930152353.078105296@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152346.024115587@linuxfoundation.org> References: <20260930152346.024115587@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wentao Liang commit 0bf6bb567f0edaa771e7dd208ef98da50e6a4485 upstream. When the reverse entry is found but its counter is already being released, refcount_inc_not_zero() fails and the reference taken by mlx5_tc_ct_entry_get() is never dropped before falling through to create_counter. Drop it so the reverse entry is not kept alive forever by a shared counter lookup that did not use it. Fixes: 1edae2335adf ("net/mlx5e: CT: Use the same counter for both directions") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang Reviewed-by: Tariq Toukan Link: https://patch.msgid.link/20260917113131.2149024-1-vulab@iscas.ac.cn Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c @@ -1082,6 +1082,9 @@ mlx5_tc_ct_shared_counter_get(struct mlx spin_unlock_bh(&ct_priv->ht_lock); + if (rev_entry) + mlx5_tc_ct_entry_put(rev_entry); + create_counter: shared_counter = mlx5_tc_ct_counter_create(ct_priv);