From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4776370AEC; Wed, 30 Sep 2026 15:43:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783035; cv=none; b=IiLFJ5J7kV0UKBebsSngDuYONHr26U/36vM5DOswMJ6jXtvpOSDfe+hSSxI+KOFGG8deHNkUutCmiQiXompsTRJhKma6VwgRdU2MDMEZwN8QFcflnHdUzu/2VWnWf0hxDnjykGZnMEGO+ZXBjUrqWqwtPW/c82v8QnM/lD0GB6U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783035; c=relaxed/simple; bh=gywDrpf5hrvBIAO1VV04dQox72EaoGe/zOssDTRvnLg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iJrLwyT/6+VrtVoTwS9Aypjc4L7UsS7H5K93szZ7zo6CYR5TdoR/ajoQxh6Ul5ITQTsgw6so0MycloxA8ptZshjGfx33wLrB6gY0eKf6jcQTdPpqMxayR+SgJ2EeOa/24Gc5mtamjPSsYAXMZbqxzg7zt0N9Q56mAN8+sj7IDDU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uxExKsp9; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uxExKsp9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DA091F00893; Wed, 30 Sep 2026 15:43:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790783032; bh=/8BwdfIN8SQB3eVhPBmFlCOfXEO8ZDiT5ygV7hLxDB8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=uxExKsp9fgI17wjwhczZWQajYKEaVZjwEp8UkbzejWM6ZVY5pRJ8PoPDLHrsS2xSw lMU0Lk7Hxr2HyLhGO2m9EFm9g+q6QYpvXaLE8SDoGcXsdi0fKqFXIh91FEQB1pPTKo XFc6pfGoilUsXyRvOCijLL+aPRvalz6srLb9SrdE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Vega , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Victor Nogueira , Jamal Hadi Salim , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 254/595] net/sched: drr: clamp quantum in change class Date: Wed, 30 Sep 2026 17:22:27 +0200 Message-ID: <20260930152353.176926992@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jamal Hadi Salim [ Upstream commit 8382abec0f1568d0a5590d75a3df92f23fcf5196 ] drr_change_class() rejects explicit quantum==0 but falls back to psched_mtu() with no floor. With a crafted size table qdisc_pkt_len reaches ~2 GiB, so quantum=1 (or a zero psched_mtu on a headerless device) makes the deficit-refill loop spin under the qdisc lock. Add clamp_t(u32, quantum, 256, 1<<20) after the zero reject and on the fallback path. The explicit-zero reject is preserved. Conditions to recreate the bug: CONFIG_NET_SCH_DRR=y. Requires CAP_NET_ADMIN (namespace-local via unshare -Urn suffices). tc qdisc add dev dummy0 root drr tc class add dev dummy0 parent 1: classid 1:1 drr quantum 1 Fixes: 13d2a1d2b032 ("pkt_sched: add DRR scheduler") Reported-by: Vega Reviewed-by: Toke Høiland-Jørgensen Tested-by: Victor Nogueira Signed-off-by: Jamal Hadi Salim Link: https://patch.msgid.link/QDISC-0CFC.v3.20260901204856@mojatatu.com.8 Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/sched/sch_drr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/sched/sch_drr.c b/net/sched/sch_drr.c index 50fbf53493a31..763beca62f5f6 100644 --- a/net/sched/sch_drr.c +++ b/net/sched/sch_drr.c @@ -83,8 +83,9 @@ static int drr_change_class(struct Qdisc *sch, u32 classid, u32 parentid, NL_SET_ERR_MSG(extack, "Specified DRR quantum cannot be zero"); return -EINVAL; } + quantum = clamp_t(u32, quantum, 256, 1 << 20); } else - quantum = psched_mtu(qdisc_dev(sch)); + quantum = clamp_t(u32, (u32)psched_mtu(qdisc_dev(sch)), 256, 1 << 20); if (cl != NULL) { if (tca[TCA_RATE]) { -- 2.53.0