From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C02024FE2D3; Wed, 30 Sep 2026 15:49:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783373; cv=none; b=rmwbw/U+0MvueS/vJrgHl9nGwabsus6OxKf8UUxfT6ARTHCU0ScRlO82GsBqReNvVI7czktkneCpcRIpTmMKO/JvuLx2NbvPrBJk60x4W4rD/H0A6sMrEWtpvEBBWx+P3JK6mnjR3pfiH2lasnJUjov6YUOR6/oQCYIoaU0K6Bs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783373; c=relaxed/simple; bh=CEPeFVHYozIt5H61+diJMnkA2mqfu1O5dRH18z3tdDA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FqMyrMNWSctxQmXYPX48t6f85pBprv+MhT3n9AxyfmE+MmowH5FG7Hd6JpDxO1EEOnx4GW2rnUGobXf0Jmy1gcZkyUyU5JikMvNCsr8rLzzNBm/Q5qjYvhLwiBkNqx47WQtn2h8SKNWfU8nHKlyBgoYt6zff9a7+t6cz8vB1zIc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=vcaYw7Cu; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="vcaYw7Cu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D6961F000FF; Wed, 30 Sep 2026 15:49:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790783367; bh=qL3ByNdZhrCgujJ2dY702HlhbFU94y4J+E70i3bDods=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=vcaYw7Cuz2LVBz3ScM2Qg3wu6o1ayI/xg6BaDqmhaxAClj+7ddzsmyZwz6nxTvXYQ E5h4BCItcwsNXvBbady7OWC0vgjs1YdGuJEQB+ONJroyCwskqRDNcrkT3YHnlYhAFz a1QZ44jicdI0JwjhnpMrLVstiowE8lFxXqQ5szRE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bard Liao , David Lin , Shuming Fan , Pierre-Louis Bossart , Vinod Koul , Sasha Levin Subject: [PATCH 5.10 374/595] soundwire: cadence_master: wait and cancel cdns->work before clock stop Date: Wed, 30 Sep 2026 17:24:27 +0200 Message-ID: <20260930152355.721721120@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bard Liao [ Upstream commit aba7b41faeecb7692458095ce6fafc341fe0b80e ] A peripheral event could happen during the clock stop process. We need to wait for the event be handled before stopping the bus clock. Otherwise, we will get the IO transfer timed out issue. Fixes: af4cc917826f ("soundwire: cadence: mask Slave interrupt before stopping clock") Signed-off-by: Bard Liao Reviewed-by: David Lin Reviewed-by: Shuming Fan Reviewed-by: Pierre-Louis Bossart Link: https://patch.msgid.link/20260901031019.233254-1-yung-chuan.liao@linux.intel.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/soundwire/cadence_master.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c index d3e9cd3faadfd..034589453597e 100644 --- a/drivers/soundwire/cadence_master.c +++ b/drivers/soundwire/cadence_master.c @@ -1416,6 +1416,13 @@ int sdw_cdns_clock_stop(struct sdw_cdns *cdns, bool block_wake) return 0; } + /* + * wait for any in-flight peripheral event handling to complete before stopping the clock. + * No need to disable peripheral interrupts before canceling the work, as the peripheral + * interrupts are already masked before the work is scheduled. + */ + cancel_work_sync(&cdns->work); + /* * Before entering clock stop we mask the Slave * interrupts. This helps avoid having to deal with e.g. a -- 2.53.0