From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 620FA4FE2E8; Wed, 30 Sep 2026 15:51:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783512; cv=none; b=i9Ua1HKKXUGMXRuzJQfKBhhaapakWlHA1ZVI0tEh2X9c3SGuNm1CECfsAua6poCyuvOE18avkJEPREXBuc4xcKZGrKZHTELY5nnHFF8akOrTPEENM2A0cN+Ju2tmU24WBuKV9GGo4VD5f1+tKvwPJbfr6wBWrD7B1Ij51Bh1g9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783512; c=relaxed/simple; bh=uyFooiNPbCIzt+A5mJ8R++ULjDXxGqR7cpbkv6XOzgs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PPHY3P5DQESs6dKVVpHsHHdI+wICqBV3cu+muATw1K8TPfOR+phBgm7r8xklojcQLpZyz95jP8SDTyxTcXs0nxI4dqF2E+OFfaF6iyB079BSXKd71RAkA5BTP7m8rgAmFBJRzIBpjYw+ifCaOC/8XiD6YfBZF4XeT24Xr3DkPvg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=fveOxp2+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fveOxp2+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 113241F000FF; Wed, 30 Sep 2026 15:51:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790783506; bh=z01Tz7F0V7gd6vONehdvRtXpCdoFIKpluKNVFqWpxL0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=fveOxp2+g8r+G9gEDmQOeNCHrHAzDO9t1lGPTNwap7jWki2rMtwy7ppxRmP8eS4nW 1sb5xFoidaH7xyJI66HyPGYPH2i2yo72ZFOGZ89m6/CI79dXKl/iAIMIgQUsrMJ2Bk pNuhZZGYWCsjV6RQpiNWmLraDpzhzb+k9hUl9xcg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+bd317784d628820741b5@syzkaller.appspotmail.com, Jeffin Philip , Leon Romanovsky Subject: [PATCH 5.10 423/595] RDMA/core: fix refcount bug in iwpm_get_nlmsg_request() Date: Wed, 30 Sep 2026 17:25:16 +0200 Message-ID: <20260930152356.776422417@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jeffin Philip commit 33fb59da49c4c3f5c2ec9f9d4447a56857a02c02 upstream. iwpm_get_nlmsg_request() initializes refcount _after_ list_add_tail() making it accessible to global list where another CPU can kref_get() on nlmsg_request causing a refcount "addition on 0" bug. Fix this by initializing kref _before_ list_add_tail() so refcount for nlmsg_request can be incremented/decremented normally. In addition, also initialize every field before list_add_tail(). Reported-by: syzbot+bd317784d628820741b5@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=bd317784d628820741b5 Fixes: 30dc5e63d6a5 ("RDMA/core: Add support for iWARP Port Mapper user space service") Cc: stable@vger.kernel.org Signed-off-by: Jeffin Philip Link: https://patch.msgid.link/20260904131437.12917-1-jeffinphilip14@gmail.com Signed-off-by: Leon Romanovsky Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/core/iwpm_util.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) --- a/drivers/infiniband/core/iwpm_util.c +++ b/drivers/infiniband/core/iwpm_util.c @@ -348,10 +348,6 @@ struct iwpm_nlmsg_request *iwpm_get_nlms if (!nlmsg_request) return NULL; - spin_lock_irqsave(&iwpm_nlmsg_req_lock, flags); - list_add_tail(&nlmsg_request->inprocess_list, &iwpm_nlmsg_req_list); - spin_unlock_irqrestore(&iwpm_nlmsg_req_lock, flags); - kref_init(&nlmsg_request->kref); kref_get(&nlmsg_request->kref); nlmsg_request->nlmsg_seq = nlmsg_seq; @@ -360,6 +356,11 @@ struct iwpm_nlmsg_request *iwpm_get_nlms nlmsg_request->err_code = 0; sema_init(&nlmsg_request->sem, 1); down(&nlmsg_request->sem); + + spin_lock_irqsave(&iwpm_nlmsg_req_lock, flags); + list_add_tail(&nlmsg_request->inprocess_list, &iwpm_nlmsg_req_list); + spin_unlock_irqrestore(&iwpm_nlmsg_req_lock, flags); + return nlmsg_request; }