From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D4B450B43D; Wed, 30 Sep 2026 15:52:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783553; cv=none; b=h+I5oLErphI/gecrS8YjOwzjt53jivH9BdjmcrzIcWMV4FdiXKoBvLln58DnKnBF/NwRmP+AgtZUCVdouWWSNIhvDkLwVOHCGqD7g2l70IbllAMInx7hVYPx+D7kw1cfpFimGyG0HyyGJfIWe8BExqie5/HGcnWGVSxJnywbA2U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783553; c=relaxed/simple; bh=xdlygHdam8I0fRUADC51sUAmCIJ6R8O5ebqt1iOrGcE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EI9jDNbZMmJN9lILBDq7syYschOUNoNlcYjeFvfbogAmTVsoDSn3mE3pcLGODhVcCMXrEmtSB98g3hF0FtdRQIy2Xru77Z2HR8LWqRpyK2xeUUezX5s8VJKcfNSg6wD0q78uA4+3T0UE55EZNDAEbrVB6f8pBQgbtcwY5CXF83g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=rGcR09SR; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="rGcR09SR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67AD81F00898; Wed, 30 Sep 2026 15:52:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790783548; bh=z3UIQ0E7ioBhzbiLaETl3b4tztZe0zeeEbh9s7X1Lww=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=rGcR09SRUzMO10D6+t+PU4EYep1DLEMNXnB3CqziuESYDDUSPPWEbzWkrk9Zp9k0/ J2uFfe1bDWornApFL3abZScHYKn/4Jef0352Z7d/IDi7QM7FEmOqVV7OkcWQIbhkhU 7GCs04HSSNft+y8ZZcYeK27UuBfpY6/fHaTEQUYA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shengzhuo Wei , Mukesh Kumar Savaliya , Andi Shyti Subject: [PATCH 5.10 437/595] i2c: at91: release DMA channels on remove and probe error Date: Wed, 30 Sep 2026 17:25:30 +0200 Message-ID: <20260930152357.080485377@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shengzhuo Wei commit f7eeb1af8537b05953fb1c88ab8b59d94059a381 upstream. at91_twi_configure_dma() requests exclusive tx/rx DMA channels, but nothing ever releases them on driver detach, and the probe error path after the channels are acquired (i2c_add_numbered_adapter() failure) returns without releasing them either, because the remove callback is not invoked after a failed probe. Move the release into a helper, call it from the existing configure-failure path, the adapter-registration failure path, and at91_twi_remove(). Fixes: 60937b2cdbf9 ("i2c: at91: add dma support") Assisted-by: GLM:5.3 Signed-off-by: Shengzhuo Wei Cc: # v3.8+ Acked-by: Mukesh Kumar Savaliya Signed-off-by: Andi Shyti Link: https://patch.msgid.link/20260827-i2c-dma-channel-leak-v1-1-271d4adc03a0@cherr.cc Signed-off-by: Greg Kroah-Hartman --- drivers/i2c/busses/i2c-at91-core.c | 3 +++ drivers/i2c/busses/i2c-at91-master.c | 12 +++++++++++- drivers/i2c/busses/i2c-at91.h | 1 + 3 files changed, 15 insertions(+), 1 deletion(-) --- a/drivers/i2c/busses/i2c-at91-core.c +++ b/drivers/i2c/busses/i2c-at91-core.c @@ -264,6 +264,7 @@ static int at91_twi_probe(struct platfor pm_runtime_disable(dev->dev); pm_runtime_set_suspended(dev->dev); + at91_twi_dma_release(dev); return rc; } @@ -280,6 +281,8 @@ static int at91_twi_remove(struct platfo i2c_del_adapter(&dev->adapter); clk_disable_unprepare(dev->clk); + at91_twi_dma_release(dev); + pm_runtime_disable(dev->dev); pm_runtime_set_suspended(dev->dev); --- a/drivers/i2c/busses/i2c-at91-master.c +++ b/drivers/i2c/busses/i2c-at91-master.c @@ -820,11 +820,21 @@ static int at91_twi_configure_dma(struct error: if (ret != -EPROBE_DEFER) dev_info(dev->dev, "can't get DMA channel, continue without DMA support\n"); + at91_twi_dma_release(dev); + return ret; +} + +void at91_twi_dma_release(struct at91_twi_dev *dev) +{ + struct at91_twi_dma *dma = &dev->dma; + if (dma->chan_rx) dma_release_channel(dma->chan_rx); if (dma->chan_tx) dma_release_channel(dma->chan_tx); - return ret; + dma->chan_rx = NULL; + dma->chan_tx = NULL; + dev->use_dma = false; } static int at91_init_twi_recovery_gpio(struct platform_device *pdev, --- a/drivers/i2c/busses/i2c-at91.h +++ b/drivers/i2c/busses/i2c-at91.h @@ -174,6 +174,7 @@ void at91_twi_irq_restore(struct at91_tw void at91_init_twi_bus(struct at91_twi_dev *dev); void at91_init_twi_bus_master(struct at91_twi_dev *dev); +void at91_twi_dma_release(struct at91_twi_dev *dev); int at91_twi_probe_master(struct platform_device *pdev, u32 phy_addr, struct at91_twi_dev *dev);