From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 697504E01E3; Wed, 30 Sep 2026 15:53:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783606; cv=none; b=nDRkr84KmYRHRJdIJ15/UN62LvI0EqKHng3rS0CDsbnmvdMSgzMd0Itt5UOz5XB6Rggd3VkbNBj9xY3lCHHudP3opMJNpRC4GjIw5CVsZTAxAUGuxOYsjzUmXkyvjpA1VuNdHhnSpgdiu8TRzaSOlxOkLE6TEJVytF/uJVs5se8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783606; c=relaxed/simple; bh=VxF6/wDMzjoHCHziqtX9XlkMWN1RG1DmLzYrf2ztJJc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SpH/FDixRe42mKwliFgkYoGzig5SH2WmZV2HbNbEPK+ilm9dhPh/kVXr1NvkMYExUmLYWv3PRLqmdNrMicKPXFIMD4BmnLyCi8beUB4QxzfCUSyi+FriqdrwImNGLHOCcUrnZYDW1+q2110tF7O6xbYNmwZ4f7rJA1uKu2VLZcM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=BroU/g50; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="BroU/g50" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 630511F00893; Wed, 30 Sep 2026 15:53:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790783602; bh=/QtLWpNK0VXVMstaF4Q+4kOkMUbRj72ucT5jMT/5TXU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=BroU/g50kYYCq8RRB6Ugn7JdsEFzmTec6hblLwNoFW0LfJCrS7LXTdNmBd8G8AIEh /vkddHV5d+vnNrGSj3KaWmthgprWNCYiVW5t92RqWsZqVGs1Ubx8rIqufmKMrHHbL9 sg9WCmq0qMj+NOpd3j+dsExxzcOiN/j3NiGgPC7o= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guangshuo Li , Guenter Roeck Subject: [PATCH 5.10 458/595] hwmon: (w83793) release probe data through kref Date: Wed, 30 Sep 2026 17:25:51 +0200 Message-ID: <20260930152357.533888869@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guangshuo Li commit c702a5f18b780e477eccbbab558e590e9673e4cb upstream. w83793_probe() initializes data->kref to manage the lifetime of the driver data. The normal remove path drops the driver-owned reference with kref_put(), while watchdog users take and release additional references through the same kref. However, the probe error path still frees data directly with kfree(). This bypasses the kref-managed lifetime and discards the initial reference without a matching kref_put(), leaving the reference accounting unbalanced. Drop the probe-owned reference with kref_put() instead and let w83793_release_resources() perform the final free, matching the normal remove path. This issue was found by manual code inspection. Fixes: 5852f9609d21 ("hwmon: (w83793) Add watchdog functionality") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Link: https://patch.msgid.link/20260914073638.1662500-1-lgs201920130244@gmail.com Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- drivers/hwmon/w83793.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/hwmon/w83793.c +++ b/drivers/hwmon/w83793.c @@ -1931,7 +1931,9 @@ exit_remove: for (i = 0; i < ARRAY_SIZE(w83793_temp); i++) device_remove_file(dev, &w83793_temp[i].dev_attr); free_mem: - kfree(data); + mutex_lock(&watchdog_data_mutex); + kref_put(&data->kref, w83793_release_resources); + mutex_unlock(&watchdog_data_mutex); exit: return err; }