From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF2654F4047; Wed, 30 Sep 2026 15:56:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783765; cv=none; b=MAUzXT4Cwik/avwtdFW7z8+SqTpnoP16ISTvbqmh39PSc8KL09Jdn/1mkLFzsDZK3JzWBSu2yMuOpzKpJ+OtfgdiaFhD8vo02Jeggm7Rt2G21pM2eSFlClySxKR01tvfaGv43Ij+W4CVMFmEQy6TK0YTQPUvoksH1DTfTY0KxSU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790783765; c=relaxed/simple; bh=AGYvoJCojWz8oPU+gcudK+RlLmdLV4D5PjRfxLAxiso=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SvMEqAO3Urqj17Fo6w9yvQ3DO7T12/tNLQnjt+E/LCMKSry5N6T2ozL5uh/0afApCZ3SLOPDH8jFYr3Lda0mciCymyTSFydzPsZ0Oa24U1oHXn++p5PJ8+gTIeCyY2vuPSGd0l6m1xHBzObUDt77km7qKPXbuIm8aY5iBvBuj/U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Us1lTIYU; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Us1lTIYU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B2FC1F000FF; Wed, 30 Sep 2026 15:56:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790783761; bh=Er40npCHcEODdpa60MhOumwrkk9NyagwLNb51GPMB/0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Us1lTIYUSCskzAgKznvTS27K1VMyoVGFs777wuY6uLDtsGBhp+/1ZNl2rB6eBFs7/ AErjT+S8oYvxxDocuC0S6zzkPDy6PaxyRvwlmEGzRqHsGhclr7YxYVytah11m6nJAv v4CpJmCWFg73cVo19nsFx4Oqm9pHyQmgAWm898aI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, bui duc phuc , Simon Horman , Paolo Abeni , Sasha Levin Subject: [PATCH 5.10 514/595] net: ethernet: ti: netcp: fix pm_runtime usage counter leak on error Date: Wed, 30 Sep 2026 17:26:47 +0200 Message-ID: <20260930152358.757571240@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: bui duc phuc [ Upstream commit ac4334522e4ba4a3b6710dd5d4cc98092824b8ca ] pm_runtime_get_sync() leaves the runtime PM usage counter incremented even when it fails, but the error path in netcp_probe() does not call pm_runtime_put_noidle() to balance it, leaking a reference each time resume fails. Use pm_runtime_resume_and_get() instead, which automatically drops the usage counter on failure, fixing the leak. Fixes: 84640e27f230 ("net: netcp: Add Keystone NetCP core ethernet driver") Signed-off-by: bui duc phuc Reviewed-by: Simon Horman Link: https://patch.msgid.link/20260918042804.13101-1-phucduc.bui@gmail.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/ethernet/ti/netcp_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c index 77dd20431c447..7c209a749c1e8 100644 --- a/drivers/net/ethernet/ti/netcp_core.c +++ b/drivers/net/ethernet/ti/netcp_core.c @@ -2171,7 +2171,7 @@ static int netcp_probe(struct platform_device *pdev) return -ENOMEM; pm_runtime_enable(&pdev->dev); - ret = pm_runtime_get_sync(&pdev->dev); + ret = pm_runtime_resume_and_get(&pdev->dev); if (ret < 0) { dev_err(dev, "Failed to enable NETCP power-domain\n"); pm_runtime_disable(&pdev->dev); -- 2.53.0