From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D6C947140E; Wed, 30 Sep 2026 16:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790784009; cv=none; b=NS7ZuWOAN5/hsd+Q8oNyI4GvcKMRzXfxwAI6t32HxcUXPjqnwWdSJUG27y//Kr4o6h2Mxf71Np/yadm71z9ng2enmgJF+ydOm2wBIf+iTtlrHTCabflV3gpLpWm0jmoH67Yxv8qANh7qzO3S7AN4WCAtFalUNzJPzUDokOS7giI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790784009; c=relaxed/simple; bh=sFMPbO2NxIA1ySJk+JdRCXvGWuC5PXXvcjUT3Q+HU+0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lyz2NaFh1e6vWiCPJOIGIHHTwgVQkzy26ygHq7QgBjfkT8nPRE/p4JI0mS/dBoBqXwcN+ypsE83AJXVmsuSO3aAJivFwNNZ9gLMI7yGc2Rt70kUuE0ldE+4DVuCZYBnD/q9T3mMUSePulU3ROzA7SGoHxSpi80xukFp8UDTEv+U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=vnLh7iln; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="vnLh7iln" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF2181F000FF; Wed, 30 Sep 2026 16:00:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790784003; bh=s7tpApA4Kcuu/EGPLe6cxyeJVjJ6h0LzkTqr3V37RpA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=vnLh7ilnCdsCEtYTYfz99Ac4dVBzJ7PrshHkbQlsAlhAOZHNJnph5ogcTL6T8QHRR Lep93qFxwi9uRsXkSUSseMDtNrQcP1ATHFgI9d0WYPPVr96nRJ+LlTX9s0IGeS8IZM O7pgGt/ak+MMFttvKrs1NuwbN+NdTRn08V1jrS0E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jamal Hadi Salim , Jiri Pirko , Eric Dumazet , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 543/595] net/sched: sch_teql: fix shadowed err in __teql_resolve() Date: Wed, 30 Sep 2026 17:27:16 +0200 Message-ID: <20260930152359.391170814@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152347.700140858@linuxfoundation.org> References: <20260930152347.700140858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Dumazet [ Upstream commit 907b978e82cb4c1c245fc2985bb27c5d5c88c8f6 ] __teql_resolve() declares an inner 'int err;' inside the 'if (neigh_event_send(n, skb_res) == 0)' block, shadowing the outer 'int err = 0;'. As a result, a negative return from dev_hard_header() is written to the inner variable and __teql_resolve() still returns 0. Remove the shadowed variable and set the outer err to -EINVAL when dev_hard_header() returns a negative error. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Closes: https://lore.kernel.org/netdev/179022851638.2160803.1808206741379444999@kernel.org/ Cc: Jamal Hadi Salim Cc: Jiri Pirko Signed-off-by: Eric Dumazet Link: https://patch.msgid.link/20260924082951.1599377-4-edumazet@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/sched/sch_teql.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/net/sched/sch_teql.c b/net/sched/sch_teql.c index e78a849fb1b0b..00ac4386627c7 100644 --- a/net/sched/sch_teql.c +++ b/net/sched/sch_teql.c @@ -242,14 +242,11 @@ __teql_resolve(struct sk_buff *skb, struct sk_buff *skb_res, } if (neigh_event_send(n, skb_res) == 0) { - int err; char haddr[MAX_ADDR_LEN]; neigh_ha_snapshot(haddr, n, dev); - err = dev_hard_header(skb, dev, ntohs(skb_protocol(skb, false)), - haddr, NULL, skb->len); - - if (err < 0) + if (dev_hard_header(skb, dev, ntohs(skb_protocol(skb, false)), + haddr, NULL, skb->len) < 0) err = -EINVAL; } else { err = (skb_res == NULL) ? -EAGAIN : 1; -- 2.53.0