From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 605D32EEE63; Wed, 30 Sep 2026 17:59:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790791197; cv=none; b=pkNz3EV3l4ziczjNKWm8rvZlZOoXuZnKMNrv2Le07+ybMZn7tZtCbe9lZySyJRq5qPSrWFkGTvD6B+Y3yNzxcgbtoYgs39LdEiIzBUwL5qkFc9dSYOJ5krcZGc0vxUaUqLWpBmXcFZKMC7skQIli23Jdc11pZdBvAtlspPRd5Tw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790791197; c=relaxed/simple; bh=AAfnGh3JwXnXXE29jm5hwmL29BJn/EzaOGitBNW0DVc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tEwLJPNF3qTDt895BXQHw12sP2bmTWFDq2sCJeThupLeJv8RkdmaF+FIt3Qx39xvvi4BfacA/DUsXj3guS3YnxR86Rhi7p6Ytxw8oCALlYNTBWVkpYOr4ZWwDQ/2NaIasF8Q/6Mo0WvgefJBnoQp4nwDrjEQrYQxGK53TEC/dhQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=V0BQAWzT; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="V0BQAWzT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA8881F000FF; Wed, 30 Sep 2026 17:59:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790791196; bh=hCjenpffH5MLDGNa7XDuokVDmiJnHCHHGyZQylepHm0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=V0BQAWzTyqH89PhK75EE48bsO2gZTU83hPXw3iwPPUd9v1HyxI95TeOHiNjp0Lrf5 GtF0Jpk/tPz8NcVczd6fbx2eB0Zo2Tlud7QqInUeaHEGOCauQBMY21QCv3kVAQNtGV tatJlPqz6E0tMB18k56QhX7YJVDJ6RmTYdCyliKQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ibrahim Hashimov , Johannes Berg , Sasha Levin Subject: [PATCH 5.15 216/752] wifi: mac80211_hwsim: reject undersized HWSIM_ATTR_TX_INFO Date: Wed, 30 Sep 2026 17:21:26 +0200 Message-ID: <20260930152402.923660003@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152358.131179731@linuxfoundation.org> References: <20260930152358.131179731@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ibrahim Hashimov [ Upstream commit 3dc723ac78a6e4fa0fd49e27e487ed319da40a9f ] hwsim_tx_info_frame_received_nl() casts the HWSIM_ATTR_TX_INFO payload to a struct hwsim_tx_rate * and unconditionally reads IEEE80211_TX_MAX_RATES entries (8 bytes) from it. The policy only bounds the attribute from above (NLA_BINARY .len is a maximum) and the op sets GENL_DONT_VALIDATE_STRICT, so a short or zero-length attribute is accepted and the loop reads past the payload. Require the exact length in the policy, so a malformed attribute is rejected before the handler runs. Signed-off-by: Ibrahim Hashimov Assisted-by: AuditCode-AI:2026.07 Link: https://patch.msgid.link/20260721115346.17236-1-security@auditcode.ai Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- drivers/net/wireless/mac80211_hwsim.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c index 9c102c25a5332..6bf9a0309dfd3 100644 --- a/drivers/net/wireless/mac80211_hwsim.c +++ b/drivers/net/wireless/mac80211_hwsim.c @@ -738,9 +738,9 @@ static const struct nla_policy hwsim_genl_policy[HWSIM_ATTR_MAX + 1] = { [HWSIM_ATTR_FLAGS] = { .type = NLA_U32 }, [HWSIM_ATTR_RX_RATE] = { .type = NLA_U32 }, [HWSIM_ATTR_SIGNAL] = { .type = NLA_U32 }, - [HWSIM_ATTR_TX_INFO] = { .type = NLA_BINARY, - .len = IEEE80211_TX_MAX_RATES * - sizeof(struct hwsim_tx_rate)}, + [HWSIM_ATTR_TX_INFO] = + NLA_POLICY_EXACT_LEN(IEEE80211_TX_MAX_RATES * + sizeof(struct hwsim_tx_rate)), [HWSIM_ATTR_COOKIE] = { .type = NLA_U64 }, [HWSIM_ATTR_CHANNELS] = { .type = NLA_U32 }, [HWSIM_ATTR_RADIO_ID] = { .type = NLA_U32 }, -- 2.53.0