From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 538634DEC26; Wed, 30 Sep 2026 18:18:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790792340; cv=none; b=eTQ47mMi7wXETImmeEWUAbSEc3C7t7sew4XRUe47DAdEti1bT37P0B/llpeZ0CbjruWbI7rRGMs/brBrDloWTPDhvBZ5Qz02wioslfdRW+i5U7kt84GyMKQdWpz+AnKNCrhZnz7TZAv02Q3DRKhuGU1u8Ous6e4k/tGrtW717bw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790792340; c=relaxed/simple; bh=9PUN+Vm5FwJ+RLcPxLTos6ubAdQ5J5rmTC+pa0te69k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UU6zAMzbJ7eTu1IY0NnrZdHH9NYfR3O9e+ZChFiSUpfe4Ws3JtH94/im7lOi1ZH22EFQMiUDtBttcYVq1Mc982NKv2b0Qln/mvqlb0C44U9QNxtNUekAagoB5XCb2SmAuDEqKkw43ToAFkXLHFVCZopG0ljQXpEVpqglEDvMy/U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=dMTKcEBu; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dMTKcEBu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A75BF1F000FF; Wed, 30 Sep 2026 18:18:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790792339; bh=JFRNkUuFARpNDBtGRZ641fsPKl14mvrJ8bio7H4puFo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=dMTKcEBuYE3CKpNhVlz/XqzDG1kDkncR6Z+LgvGvoCb2460WTTDhDe3U8yjDvy85+ YpQVzEE7hPQlG2RdoSSi5Eft4IMvwKcYAxLiCNarfK3IJuw/w6Ap6G/fawnYUQHlf7 oCtXPuBEUxa34OLN1ZI+x8iXL/1p5oh1ozdmX2n8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , Francesco Magazzu , Lyude Paul , Sasha Levin Subject: [PATCH 5.15 621/752] drm/nouveau/clk: fix list cursor use after loop in nvkm_clk_ustate_update Date: Wed, 30 Sep 2026 17:28:11 +0200 Message-ID: <20260930152411.715864962@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152358.131179731@linuxfoundation.org> References: <20260930152358.131179731@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter [ Upstream commit aff09d9e37e02dc60bde79035ac15b136d602259 ] If list_for_each_entry() exits without hitting a break then "pstate" is not a valid pstate pointer. Introduce a "found" variable instead. The check is reachable from userspace: nvkm_clk_ustate_update() takes the pstate id straight from the 'pstate' debugfs file, so requesting an id that is not in clk->states - or any id at all when the perf tables are broken and the list is empty - makes the pstate->pstate != req test dereference the list head cast to a struct nvkm_pstate, which is an out-of-bounds read. Fixes: 7c8565220697 ("drm/nouveau/clk: implement power state and engine clock control in core") Signed-off-by: Dan Carpenter [Francesco: rebased on drm-misc-next, expanded the commit message] Signed-off-by: Francesco Magazzu Reviewed-by: Lyude Paul Signed-off-by: Lyude Paul Link: https://patch.msgid.link/20260918131620.405133-2-postadelmaga@gmail.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/nouveau/nvkm/subdev/clk/base.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/clk/base.c b/drivers/gpu/drm/nouveau/nvkm/subdev/clk/base.c index c2b5cc5f97eda..7c7f7c1c8d383 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/clk/base.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/clk/base.c @@ -474,6 +474,7 @@ static int nvkm_clk_ustate_update(struct nvkm_clk *clk, int req) { struct nvkm_pstate *pstate; + bool found = false; int i = 0; if (!clk->allow_reclock) @@ -481,12 +482,14 @@ nvkm_clk_ustate_update(struct nvkm_clk *clk, int req) if (req != -1 && req != -2) { list_for_each_entry(pstate, &clk->states, head) { - if (pstate->pstate == req) + if (pstate->pstate == req) { + found = true; break; + } i++; } - if (pstate->pstate != req) + if (!found) return -EINVAL; req = i; } -- 2.53.0