From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 354DD51C041; Wed, 30 Sep 2026 18:22:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790792580; cv=none; b=imONGY5FhonwCuD0BoJlvXJHPjGoY4r8z9Z5yYlzc4aEiJltxvAN+FGFJCduEMAQeaoh32bh8bv88Y6iYchdeE4vrgARL8LwQbb3BOuOvq5poxb+RiGi4gtw0BgaTFTiWhUMsG6iJHBN1hhuG0BHX2wMGWEXe5vRIdNe24Qf2bA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790792580; c=relaxed/simple; bh=/ekwNg4QP1QK9v18TKy5atqTdDNerx3jnSYsKcofjIM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ab5udTE/r5Fa/QvgEiVjG+SJak2K/AgGCA9K7CSToV9DITgBxmtJfkyjtRiepTghX7uN+IDUuwO/hUvPxqpfC2IH8IGgHqdOmhrSwiiG4H+DZMY4MlXGqNUVlTaONeQroYLqzv2EIVfxUk59m5A89avvzO/CTfBEfQRC+EkHWDA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2mVAQ4yX; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2mVAQ4yX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90E521F000FF; Wed, 30 Sep 2026 18:22:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790792579; bh=MgSxhZgtgRZVgynPsxgI6GJP4zNjes4mVq0zY4nZsAY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=2mVAQ4yXIs5Ie3oTkq8KQ25TNxJu3pkoECujco0zHDnpKIfdI4JuPCU/Bq8+elq6I uUNy3kNVEB9AoQtfznvWL7NgU9UwNnK0T+Mjm2oCstSUpxlPxGGam5QV5qdqLq+7nt dyMMGUoI9Qj9ZUuUx/kCMq+sX4uZVzHgOI8Be1/Y= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?=C3=96mer=20Mete=20Kaya?= , David Heidelberg , Sasha Levin Subject: [PATCH 5.15 659/752] nfc: llcp: fix -ENOMEM on connect with zero-length service name Date: Wed, 30 Sep 2026 17:28:49 +0200 Message-ID: <20260930152412.517985430@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152358.131179731@linuxfoundation.org> References: <20260930152358.131179731@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ömer Mete Kaya [ Upstream commit c04981e42d94f39c1dba965cc462a046e946a6c5 ] When service_name_len is 0, kmemdup() returns ZERO_SIZE_PTR which passes the NULL check, causing nfc_llcp_send_connect() to attempt building a zero-length service name TLV and fail with -ENOMEM. Fix by setting service_name to NULL directly when service_name_len is 0. Fixes: d646960f7986 ("NFC: Initial LLCP support") Signed-off-by: Ömer Mete Kaya Link: https://patch.msgid.link/20260909122029.34081-1-omermetekaya0@gmail.com Signed-off-by: David Heidelberg Signed-off-by: Sasha Levin --- net/nfc/llcp_sock.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/net/nfc/llcp_sock.c b/net/nfc/llcp_sock.c index 5affde14e5908..f0e722933c1ea 100644 --- a/net/nfc/llcp_sock.c +++ b/net/nfc/llcp_sock.c @@ -761,12 +761,16 @@ static int llcp_sock_connect(struct socket *sock, struct sockaddr *_addr, llcp_sock->service_name_len = min_t(unsigned int, addr->service_name_len, NFC_LLCP_MAX_SERVICE_NAME); - llcp_sock->service_name = kmemdup(addr->service_name, - llcp_sock->service_name_len, - GFP_KERNEL); - if (!llcp_sock->service_name) { - ret = -ENOMEM; - goto sock_llcp_release; + if (llcp_sock->service_name_len == 0) { + llcp_sock->service_name = NULL; + } else { + llcp_sock->service_name = kmemdup(addr->service_name, + llcp_sock->service_name_len, + GFP_KERNEL); + if (!llcp_sock->service_name) { + ret = -ENOMEM; + goto sock_llcp_release; + } } nfc_llcp_sock_link(&local->connecting_sockets, sk); -- 2.53.0