From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA2155172F5; Wed, 30 Sep 2026 18:25:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790792713; cv=none; b=TE3kzlxr8nxu0iTehbg5p04t0OHBPeXKSS+3z+I9LJXa7vU4DEenixV40YCrsY/+t9+Q6vjUGPFXEvlFEpnid6x5k9lHjeYNSHMGlY6jgHO/ZCtbnOE81IKfSjsLdk/CIFUD32SMeDWnU3/EEZB15orBoDXMo5HFMO1vAxeZ/9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790792713; c=relaxed/simple; bh=dZM3EmQ6BYhhU7vFOOq6aqrTbpfpNNxRRS6QY9/ht7s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ouYYrEctGg1Uj4so88ZRUqxvvUv8gp5+q2u14Xyd4Sm1vwUkOtjF/GLhBNv+/xqN18oMamTubZgH6I6aUZQU4pIdp++CthJmjoMYTKnRe9MX8XH+jK4bt1iVAcei/E45WyePncqIsWg7dCpBwvrE4MSkTmI9UsE70MOMhiDX+uc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=h3g+EJ1L; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="h3g+EJ1L" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F30B1F000FF; Wed, 30 Sep 2026 18:25:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790792712; bh=82AuJU7Uztlo9WkqdBJEXADuYLNPuJF/6QW2nw5z5d4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=h3g+EJ1LwqFWMMQAFL/FTbEfLYwzAtp8OjHaAwMCG4m+SMjdF+BXmYp4JSxGp048D PnglIhRpFsP9qaAvhClnzxVMohhs9P/yeFMPOcKTTzBhmoiHBm6Ffp0GIUO+OUJBoU 5SEh2CuFDN21l96fjcd0vexSoKcgr7/cVtaX8Xcw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guangshuo Li , Lyude Paul Subject: [PATCH 5.15 708/752] drm/nouveau: fix autosuspend cleanup during teardown Date: Wed, 30 Sep 2026 17:29:38 +0200 Message-ID: <20260930152413.550871973@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152358.131179731@linuxfoundation.org> References: <20260930152358.131179731@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guangshuo Li commit fefd9480ec361969f1a836df46326a1801062c26 upstream. nouveau_drm_device_init() calls pm_runtime_use_autosuspend(), but nouveau_drm_device_fini() does not call the matching pm_runtime_dont_use_autosuspend(). If the autosuspend delay is set to a negative value while autosuspend is enabled, the runtime PM core increments usage_count to prevent runtime suspend. Without calling pm_runtime_dont_use_autosuspend() during teardown, this reference is not dropped and usage_count remains unbalanced. The documentation for pm_runtime_use_autosuspend() also notes that it is important to undo it with pm_runtime_dont_use_autosuspend() at driver exit time, unless runtime PM was initially enabled with devm_pm_runtime_enable(). Add the missing pm_runtime_dont_use_autosuspend() call to the common device teardown path. This issue was found by manual code inspection. Fixes: 5addcf0a5f0f ("nouveau: add runtime PM support (v0.9)") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Reviewed-by: Lyude Paul Signed-off-by: Lyude Paul Link: https://patch.msgid.link/20260808134137.2864847-1-lgs201920130244@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/nouveau/nouveau_drm.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/gpu/drm/nouveau/nouveau_drm.c +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c @@ -645,6 +645,7 @@ nouveau_drm_device_fini(struct drm_devic if (nouveau_pmops_runtime()) { pm_runtime_get_sync(dev->dev); pm_runtime_forbid(dev->dev); + pm_runtime_dont_use_autosuspend(dev->dev); } nouveau_led_fini(dev);