From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87CA451354E; Wed, 30 Sep 2026 16:11:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790784716; cv=none; b=Ic6O8TWKrXSEcD2p4Y6gm/ghNqiW3U1NjPQbYgA4Rysc7DqHIprRaF1Ey1oCwG8x7s57z1Bho1CSD2Dzt2IAPKS2DhieNf2wvmkp8L0X8aAnP8Rbppvcoma1IJ2wBd5/6MuOO5R7t45pgCeqxkdLrumeyvlc406Sadvj7nTo7es= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790784716; c=relaxed/simple; bh=BJLY61JRmmHr6K0fD/H60IRE8PQvQiqwKZ3hKz3Ded4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Qerh0l6499KwYeBVcXxGZhH5zM3Fp38DTnO8Vb45CMVWm1UvvFt4CWkUr8tZ3mmmIlPZXQNr+0eRlg7PsceE0gYfgoKoMukvRjzHEbWRc9ntLg1anjcLYCVqR02AqNJ/JA9iQFGmAGXNB99IPAB9lcuB3aJrwjLb7Hy/zRvt6Pk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=O+D3Veny; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="O+D3Veny" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03F891F00898; Wed, 30 Sep 2026 16:11:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790784711; bh=cGz5dVQPyGPEdfARzZAKUU1E2s9VqILkMrEOa03RYls=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=O+D3Venyf3Y2HjUXzQyA2XsfVgXd3/q40AdOflVDwStXScjeMQoWN4OyAlZe4+Ov2 U7Gsh7KUFbA11eq2kRIxU2gb7eJcqfBg3aq69fsKAGomZwrTCPNBfbB88LDLI74o/+ Mblki3W1wjVQcZLGxQWYCmKBNcDBKLlUf58EOE5s= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pengpeng Hou , Johannes Berg , Sasha Levin Subject: [PATCH 6.1 250/982] wifi: libertas: reject short monitor TX frames Date: Wed, 30 Sep 2026 17:16:26 +0200 Message-ID: <20260930152422.164621291@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152416.775402466@linuxfoundation.org> References: <20260930152416.775402466@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pengpeng Hou [ Upstream commit 13ff543e0b2c713aedeaadadde686686e949dc78 ] In monitor mode, lbs_hard_start_xmit() casts skb->data to a radiotap TX header, skips that header, and then copies the 802.11 destination address from offset 4 in the remaining frame. The generic length check only rejects zero-length and oversized skbs, so a short monitor frame can be read past the end of the skb data. Require enough bytes for the radiotap TX header and the destination address field before using the monitor-mode header layout. Signed-off-by: Pengpeng Hou Link: https://patch.msgid.link/20260704011140.37639-1-pengpeng@iscas.ac.cn Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- drivers/net/wireless/marvell/libertas/tx.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/wireless/marvell/libertas/tx.c b/drivers/net/wireless/marvell/libertas/tx.c index 27304a98787d6..13d08022e4141 100644 --- a/drivers/net/wireless/marvell/libertas/tx.c +++ b/drivers/net/wireless/marvell/libertas/tx.c @@ -117,6 +117,13 @@ netdev_tx_t lbs_hard_start_xmit(struct sk_buff *skb, struct net_device *dev) if (priv->wdev->iftype == NL80211_IFTYPE_MONITOR) { struct tx_radiotap_hdr *rtap_hdr = (void *)skb->data; + if (skb->len < sizeof(*rtap_hdr) + 4 + ETH_ALEN) { + lbs_deb_tx("tx err: short monitor frame %u\n", skb->len); + dev->stats.tx_dropped++; + dev->stats.tx_errors++; + goto free; + } + /* set txpd fields from the radiotap header */ txpd->tx_control = cpu_to_le32(convert_radiotap_rate_to_mv(rtap_hdr->rate)); -- 2.53.0