From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B30D51DAEA; Wed, 30 Sep 2026 17:33:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790789620; cv=none; b=sk6bC8Mq03Q/vwGZTIrzCsX6uLZqePRKO2Yl2d+D7pdjg63n+EaGP5WBvxoThZ8qR20w2GxfJN8JLKdXv8MdeonARqs+W6NifhA4RkqMF50nrW5symjhku+8TCLBrf/gweeG3kthb/dFFK3AgQZH+zObeuDNafC8nM4956KpVms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790789620; c=relaxed/simple; bh=wHst6auJYfXiNnkYIxcFmCl9bgNIbMe9b2olKTReV44=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eWpYcG/RLBcNZ54jd591kNPZr1rIom7QP2WTutyjnUN4tp50qfqWL8ZAXmqkWDEcMGnmyFD3vOK4xAQPLrGUihsuyDsuuxVqFpCEmfvoCff2NcbHMn0pxJJi3sambW7qvqME9jFcjkCCPw3oes3kNhdcS6fOvH4RR9k5brL43tI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=zxR/dKCx; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="zxR/dKCx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 324481F000FF; Wed, 30 Sep 2026 17:33:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790789618; bh=K1ar9IHzBVOc07CF4A/jmOxMhq5N8WA8DNHFRt+BIbQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=zxR/dKCxaFOZVTLdwZ56CRa6sFmlFjRLwKPLZSdkxI0KQCuaafceZrMTMm7L8hX6s V7xBmm/W7IsV+6AcP+zZpvBcGfmzeEbRrlHB1sYofh3CNKYNEbrNnthhPLRknu64Ci ZdL6k0Brbhb4+hEEWDo/s6u0Hd0f6XAOp+z6PahA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Aldo Ariel Panzardo , Luiz Augusto von Dentz Subject: [PATCH 6.12 539/877] Bluetooth: hci_sock: reject out-of-range OCF values Date: Wed, 30 Sep 2026 17:24:10 +0200 Message-ID: <20260930152426.275041601@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152414.738996857@linuxfoundation.org> References: <20260930152414.738996857@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Aldo Ariel Panzardo commit e93fad891c72deb84cae49430163b384ebcc92b1 upstream. The raw HCI socket security filter has 128 OCF bits per supported OGF, but masks the 10-bit OCF with 127 before looking up the command. An unprivileged socket can therefore submit a reserved OCF that aliases an allowlisted command modulo 128. A conforming controller should reject reserved opcodes. Nevertheless, the security decision must apply to the opcode that will actually be sent, especially since controller-specific behavior is outside the host stack's control. Reject OCF values that cannot be represented by the security filter instead of aliasing them onto an unrelated command. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Aldo Ariel Panzardo Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Greg Kroah-Hartman --- net/bluetooth/hci_sock.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/net/bluetooth/hci_sock.c +++ b/net/bluetooth/hci_sock.c @@ -1886,7 +1886,8 @@ static int hci_sock_sendmsg(struct socke u16 ocf = hci_opcode_ocf(opcode); if (((ogf > HCI_SFLT_MAX_OGF) || - !hci_test_bit(ocf & HCI_FLT_OCF_BITS, + (ocf > HCI_FLT_OCF_BITS) || + !hci_test_bit(ocf, &hci_sec_filter.ocf_mask[ogf])) && !capable(CAP_NET_RAW)) { err = -EPERM;