From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C939050EBF3; Wed, 30 Sep 2026 16:31:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790785899; cv=none; b=TinJTfJP0VVS+FVOVeHimOMUsIg1z80b+ajYRLiYQeWg4HU2YrBQCM+XCiv91hlYWS1GB5DxpbzA/AmSKR5E65kIe9bXjQ42L1Za1hQEkm9xy4kS0mf+2FHABnXdnFPM83TeksQFeB+41Rc6qQNnJiOPL3prcK/B9pgGTdUoh4Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790785899; c=relaxed/simple; bh=LGtkMwRftJv4tjfLlNBUSS64+81jHvhloHW0O9N7X6M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hf05IsC7QxAf0cWAjZ7FBbPqkPVab9qETCiGnb/xAOmzcDjm3Xs/9Vmr02rRxqX8t458F/D4nvpLGLobpMGldZ1feiTSmLaFE/6aVmPUlxB8R9elJ3Ug7RNxxlhnpYmODoycIT0mo8yxInyxd00GlPaUr9SCgob36nYaXmXrwzI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=m5s6dM1V; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="m5s6dM1V" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF6351F000FF; Wed, 30 Sep 2026 16:31:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790785898; bh=dm+GqflsVB8uJok9b6UmjUxRnyRLuwpQGzAnJnrEPBk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=m5s6dM1VwRISXc5X3721sU3RlKTXgGIMGirBkoYj1U1N5/AmbWnbXVGk6gSaYzUh8 3MnbSuco7PJ3ZB+0wXPQVxbHMLZNkygrBpsmIRfqVmhGLOG0qpSvQBaHOR/A152ieO cecacN+nPgStIKf/LNmx+dOOLv222a7U0fjcWQ+o= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Karl Mehltretter , Arend van Spriel , Johannes Berg , Sasha Levin Subject: [PATCH 6.1 670/982] wifi: brcmfmac: fix lost 802.1x TX completion wakeup Date: Wed, 30 Sep 2026 17:23:26 +0200 Message-ID: <20260930152431.156443685@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152416.775402466@linuxfoundation.org> References: <20260930152416.775402466@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Karl Mehltretter [ Upstream commit 621d90169cef6c8da5b6134db5c0c4e23cdd09ce ] brcmf_txfinalize() decrements pend_8021x_cnt before a lockless waitqueue_active() check. atomic_dec() does not order the decrement against the check. The waiter can therefore observe a nonzero count while the waker observes an empty queue, losing the final wakeup and delaying key installation until the 950 ms timeout. Add smp_mb__after_atomic() to order the decrement before the queue check. wait_event_timeout() provides the matching barrier. LKMM confirms that this forbids the lost-wakeup outcome. Fixes: 21fff75d2fb6 ("brcmfmac: use wait_event_timeout for 8021x pending count") Assisted-by: Claude:claude-fable-5 Signed-off-by: Karl Mehltretter Acked-by: Arend van Spriel Link: https://patch.msgid.link/20260811082702.44521-1-kmehltretter@gmail.com Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c index 7b8104d171c51..dfb00d4548310 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c @@ -549,6 +549,8 @@ void brcmf_txfinalize(struct brcmf_if *ifp, struct sk_buff *txp, bool success) if (type == ETH_P_PAE) { atomic_dec(&ifp->pend_8021x_cnt); + /* Order the decrement before waitqueue_active() */ + smp_mb__after_atomic(); if (waitqueue_active(&ifp->pend_8021x_wait)) wake_up(&ifp->pend_8021x_wait); } -- 2.53.0