From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C9CD4FB9AF; Wed, 30 Sep 2026 16:44:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790786666; cv=none; b=f4N9SxFTwCJja3vRCyrjSIUoqOTiuxPm31nWah24DWyQ3OXhCDqp3S5pYuSNju/290GzXfS1pdi9CbG6WXhGAYXfVOlfBJgcrksc63yldxJbw+OTr6PRmCT/qfQqcoSBrNHp0Wj0yZMKJxLqYUjl/t5x85X4Ln6XiHsiUok93lA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790786666; c=relaxed/simple; bh=4U5StoSyByoEcbNNvvFEFCzbM5ME0J/m0CY4T3Y4q7w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UYMENIQPoQN2Kptf61gbrFLoupJ4nPdZwtjZ1DZNXiy5P9/vCcOa0czEykq3TglF4SCSTfDupTrR3YV0dE463LtF24McYgrip2F+fRbDuY0qx3t/MuL3vCARkw4K0jxpSlneydYjK+rOs12tQmcozWzN//5skBgIZMtAF4gcpIQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=FM4I/ueO; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FM4I/ueO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 691341F000FF; Wed, 30 Sep 2026 16:44:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790786664; bh=SfwA0wGi90EewI0nOKm+s9o19qXzPJcV/8njzVqveDo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=FM4I/ueOIWZii8IyoGBVPh6Vi52saANoClFKEc5C4s4jqMl0qgpsysTg37l9uWoAG 58TSdjdfoBrjFWkT8hxafXV91U2A+3NGUKngTLfqfPEK6lD05mGJbUnjDo0hX3TeQb NJqHxmWV5N/f7+G3cS6cfEvButxPKbzaVu1BZR6M= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guangshuo Li , Lyude Paul Subject: [PATCH 6.1 943/982] drm/nouveau: fix autosuspend cleanup during teardown Date: Wed, 30 Sep 2026 17:27:59 +0200 Message-ID: <20260930152436.993324246@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152416.775402466@linuxfoundation.org> References: <20260930152416.775402466@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guangshuo Li commit fefd9480ec361969f1a836df46326a1801062c26 upstream. nouveau_drm_device_init() calls pm_runtime_use_autosuspend(), but nouveau_drm_device_fini() does not call the matching pm_runtime_dont_use_autosuspend(). If the autosuspend delay is set to a negative value while autosuspend is enabled, the runtime PM core increments usage_count to prevent runtime suspend. Without calling pm_runtime_dont_use_autosuspend() during teardown, this reference is not dropped and usage_count remains unbalanced. The documentation for pm_runtime_use_autosuspend() also notes that it is important to undo it with pm_runtime_dont_use_autosuspend() at driver exit time, unless runtime PM was initially enabled with devm_pm_runtime_enable(). Add the missing pm_runtime_dont_use_autosuspend() call to the common device teardown path. This issue was found by manual code inspection. Fixes: 5addcf0a5f0f ("nouveau: add runtime PM support (v0.9)") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Reviewed-by: Lyude Paul Signed-off-by: Lyude Paul Link: https://patch.msgid.link/20260808134137.2864847-1-lgs201920130244@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/nouveau/nouveau_drm.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/gpu/drm/nouveau/nouveau_drm.c +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c @@ -658,6 +658,7 @@ nouveau_drm_device_fini(struct drm_devic if (nouveau_pmops_runtime()) { pm_runtime_get_sync(dev->dev); pm_runtime_forbid(dev->dev); + pm_runtime_dont_use_autosuspend(dev->dev); } nouveau_led_fini(dev);