From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 758A22F8BEE; Wed, 30 Sep 2026 18:53:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790794405; cv=none; b=Ck843M7YIA74vD3c3Bb8x77iFSKeQQPaxNTJpDMb/HhlkKAya7zepXNIp/La8sSgZhI7zz7OkjPYvklZEb/ZbbrqM0j168xtjw9+E0FnsZsNoofSUlSIs9wE4gmnGSE46LXDH8IiLcALnhjBcVA6g2oV9wYgbP8WNCXZS+GkAq8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790794405; c=relaxed/simple; bh=CYWEmNEnIOcdNqZhgWoCjNAJEnHp5xlR72+yV/auFtc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=u7Lz5TQ4Hi1n5ELGFQoEhdAdqWZ54ZfmghBJPR3uomJNRB7m7AeG1xuJRfEwM3cjRUtXNF7o+mut6LMBeATMOjCV8R3W1GlNbBqr59WsE5lng40qrTZdNfyDHFUVhgdVZk8saGsOOWUa2WNsIcBxkt+6KjIO+wV3CgmSSBHbBTE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ObH8JbhS; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ObH8JbhS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0BD11F000FF; Wed, 30 Sep 2026 18:53:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790794404; bh=wvcJ2L3fLXJHIK1FN3rVBTlv4PIsIXShqgwnuwqxUHg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ObH8JbhSKM1WO3pWN/Tml5p9BK1a73+dACeKnNEm31oQLKQrazH+qGRWSI5FOuBil JAvVRZ/kLV4t8lyg1P7cFz+mVs85MiZrdPbtOPruvlQK0JaWfvs2SIhJn23mz5fWzd Q8gS7OFEV2tavx5NYP+UC1XFYxLxX5xrv/a9NsRY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Evgenii Burenchev , Jason Wang , Zhu Lingshan , "Michael S. Tsirkin" , Sasha Levin Subject: [PATCH 6.6 0200/1193] vdpa/ifcvf: handle dev_set_name() failure in ifcvf_vdpa_dev_add() Date: Wed, 30 Sep 2026 17:14:44 +0200 Message-ID: <20260930152438.649765872@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152434.301151190@linuxfoundation.org> References: <20260930152434.301151190@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Evgenii Burenchev [ Upstream commit 4c653e85857b41a7148917f2628fae1d04a9c251 ] dev_set_name() may fail and return an error, but its return value is currently ignored and overwritten by _vdpa_register_device(). Abort device creation if dev_set_name() fails and release the device reference to avoid continuing with an improperly initialized struct device. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Evgenii Burenchev Acked-by: Jason Wang Acked-by: Zhu Lingshan Signed-off-by: Michael S. Tsirkin Message-ID: <20260226152924.38790-1-evg28bur@yandex.ru> Signed-off-by: Sasha Levin --- drivers/vdpa/ifcvf/ifcvf_main.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c index e98fa8100f3cc..1039202934caa 100644 --- a/drivers/vdpa/ifcvf/ifcvf_main.c +++ b/drivers/vdpa/ifcvf/ifcvf_main.c @@ -718,15 +718,22 @@ static int ifcvf_vdpa_dev_add(struct vdpa_mgmt_dev *mdev, const char *name, ret = dev_set_name(&vdpa_dev->dev, "%s", name); else ret = dev_set_name(&vdpa_dev->dev, "vdpa%u", vdpa_dev->index); + if (ret) { + IFCVF_ERR(pdev, "Failed to set device name"); + goto err; + } ret = _vdpa_register_device(&adapter->vdpa, vf->nr_vring); if (ret) { - put_device(&adapter->vdpa.dev); IFCVF_ERR(pdev, "Failed to register to vDPA bus"); - return ret; + goto err; } return 0; + +err: + put_device(&adapter->vdpa.dev); + return ret; } static void ifcvf_vdpa_dev_del(struct vdpa_mgmt_dev *mdev, struct vdpa_device *dev) -- 2.53.0