From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5501E5012AB; Wed, 30 Sep 2026 19:04:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790795092; cv=none; b=pmdLHUPtdLIZ1ZVRiyuPWLJoJFoRpR1DAC9UNP8MMU55o7+C6x1fh9FPkrFmkS3AlevdCsqOS1Lpg8jvB6ec+/yvy17tRthnaq3mahbCZM2oouEGxBDZ/NY6mycXKOA9cL7nA96kfyg2xTC/WNNoGrKgrsWCB2uACv1Zdva24p8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790795092; c=relaxed/simple; bh=ViLFGc1gkIAS8z6dok7JtiXeXuSKBtnD0p7MZOnmEug=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ksNI0CKHMZpsjXoFmVqtXLIZmDSdu8WadCjI3OUfaOI3VeqoG8vw9BYu3s2fmKz93IsBndPbkjTVUPlVpzaL9b+d62Etgj1HxGkqpiHcFRPVM1SvoqfPclY61QSQ4KZTu3vk8aHY/a4Lm/mJitBWFtUVYsFmJGcU3H39vbds6lY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Cssi8jr2; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Cssi8jr2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6E001F000FF; Wed, 30 Sep 2026 19:04:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790795091; bh=yFnJ5L//mTgTaFgHu8Dxe6ygJ9Fkkd9NQMcdZmfjYbg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Cssi8jr2hP6J0TafhEWGs5kwvtfI0XFuVMpphZusDJs8u0n41nD5UmghQyGu59+qK /ooGG2xd3M5lPbb+dCZDbdR4gWZ+HyXDUqZoJEECBFxTw8PY2QDk9MbGpzfihBeMy5 rfmUENEmRkxPdiEAHB33opF9nLHhD515/IAyPPM4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Johannes Thumshirn , Ivy Lopez , John Garry , "Martin K. Petersen (Oracle)" , Sasha Levin Subject: [PATCH 6.6 0440/1193] scsi: mpt3sas: Avoid out-of-bounds cpumask_of_node() call in _base_assign_reply_queues() Date: Wed, 30 Sep 2026 17:18:44 +0200 Message-ID: <20260930152443.961412947@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152434.301151190@linuxfoundation.org> References: <20260930152434.301151190@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ivy Lopez [ Upstream commit e0d26fe176a8db6ccad4ab38c5bab29391c1946b ] dev_to_node() can return NUMA_NO_NODE (-1) on systems without NUMA topology information for the PCI device, such as single-socket boards that don't expose device-to-node affinity. Passing -1 directly into cpumask_of_node() indexes node_to_cpumask_map[-1], an out-of-bounds array read caught by UBSAN: UBSAN: array-index-out-of-bounds in arch/x86/include/asm/topology.h:72:28 index -1 is out of range for type 'cpumask *[1024]' Fall back to cpu_online_mask when no NUMA node is available, rather than assuming dev_to_node() always returns a valid node index. Link: https://bugzilla.kernel.org/show_bug.cgi?id=221294 Suggested-by: Johannes Thumshirn Fixes: 728bbc6cbff7 ("scsi: mpt3sas: Affinity high iops queues IRQs to local node") Signed-off-by: Ivy Lopez Reviewed-by: John Garry Link: https://patch.msgid.link/20260825190313.24013-1-skunkolee@gmail.com Signed-off-by: Martin K. Petersen (Oracle) Signed-off-by: Sasha Levin --- drivers/scsi/mpt3sas/mpt3sas_base.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index 3e2e0bc49623d..80a9ac9d63035 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -3227,7 +3227,10 @@ _base_assign_reply_queues(struct MPT3SAS_ADAPTER *ioc) * corresponding to high iops queues. */ if (ioc->high_iops_queues) { - mask = cpumask_of_node(dev_to_node(&ioc->pdev->dev)); + int node = dev_to_node(&ioc->pdev->dev); + + mask = (node == NUMA_NO_NODE) ? + cpu_online_mask : cpumask_of_node(node); for (index = 0; index < ioc->high_iops_queues; index++) { irq = pci_irq_vector(ioc->pdev, index); -- 2.53.0