From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 202863CAA41; Wed, 30 Sep 2026 19:14:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790795685; cv=none; b=NgeTTKIXkJzjyrkZBT3v5dXBemaT2RcxXiAxzzcZEn63nckQ3xNdXCanaD/1+WxRijdNISwLc9pCgrWdhepMnn1E4HF7N2FzzNhr7yCSE+W1fUFzoHK8FPolWatqoj7BgXyTQo0tl4yKJzoGk/ZEOuQCRJQsEl8hsDECjd+M93w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790795685; c=relaxed/simple; bh=8/+gw/8fFdjq4nPeW3UJDy6+1YFCwIlhrTvWR6DVDe0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JNUkr0tqqV6kobtFVoEVrxR7t9fTXcB23/7xlNAKOhraWfkYp+IMmGnkK8DgBMzrh3jskMUlawlq+HFQ+u7bKiLN4XqE2a+yb2MjBbesY3qgaAsIs2V7yhMHlaH62UtPWcYMlHpb+pCL4icvIi9+n2ca9690DonaK3D29cCaXBo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=EhiW8TIj; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="EhiW8TIj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D1221F000FF; Wed, 30 Sep 2026 19:14:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790795683; bh=CrVRyZea2XatVMWRNsmxi/J4HzhI73vMnCZ/yLjVhQs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=EhiW8TIjokvX+aU9IhIx2AEJ6yPeGBboA4/YNOolDkl20EVSiqNhn8UL4Iv2upR6t yDePVRNlCI9r8cRPjpdeCEPlhqX2U48MwIwaXRwjJSZXBxkesZ4FtIr7LnvjVHm3cm WSQhBAXcDxpIOS2J2p/3tGKbJ6d+C1XUuyRbFtLg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Fan Wu , Guenter Roeck Subject: [PATCH 6.6 0646/1193] hwmon: (gpio-fan) Fix use-after-free in alarm work Date: Wed, 30 Sep 2026 17:22:10 +0200 Message-ID: <20260930152448.597480064@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152434.301151190@linuxfoundation.org> References: <20260930152434.301151190@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fan Wu commit a2471ed17b0e6ff7bfb6b2ea8e6e5b04c309d293 upstream. fan_alarm_irq_handler() queues fan_data->alarm_work, but nothing cancels it. fan_alarm_notify() dereferences fan_data and its hwmon device. On unbind, devres frees the interrupt, which only waits for the handler itself, and then releases the hwmon device and fan_data, so a pending fan_alarm_notify() can run after those frees. Replace INIT_WORK() with devm_work_autocancel(), registered before devm_request_irq(). The devres cleanup then frees the interrupt first, so no new work can be queued, and cancels the work while fan_data and the hwmon device are still alive. This issue was found by an in-house static analysis tool. Fixes: d6fe1360f42e ("hwmon: add generic GPIO fan driver") Cc: stable@vger.kernel.org Assisted-by: Codex:gpt-5.6 Signed-off-by: Fan Wu Link: https://patch.msgid.link/20260819033317.446191-1-fanwu01@zju.edu.cn Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- drivers/hwmon/gpio-fan.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) --- a/drivers/hwmon/gpio-fan.c +++ b/drivers/hwmon/gpio-fan.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -80,6 +81,7 @@ static DEVICE_ATTR_RO(fan1_alarm); static int fan_alarm_init(struct gpio_fan_data *fan_data) { int alarm_irq; + int err; struct device *dev = fan_data->dev; /* @@ -90,7 +92,11 @@ static int fan_alarm_init(struct gpio_fa if (alarm_irq <= 0) return 0; - INIT_WORK(&fan_data->alarm_work, fan_alarm_notify); + err = devm_work_autocancel(dev, &fan_data->alarm_work, + fan_alarm_notify); + if (err) + return err; + irq_set_irq_type(alarm_irq, IRQ_TYPE_EDGE_BOTH); return devm_request_irq(dev, alarm_irq, fan_alarm_irq_handler, IRQF_SHARED, "GPIO fan alarm", fan_data);